Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aspect ratio for non-square album art. #658

Merged
merged 2 commits into from
Nov 22, 2020

Conversation

jwalton
Copy link
Contributor

@jwalton jwalton commented Nov 22, 2020

If you have non-square album art for an album (maybe you ripped music from a DVD and have a DVD-sized cover, or maybe you just enjoy the Cat Face theme song more than you should and you grabbed a YouTube thumbnail for the cover art), then Navidrome messes up the aspect ratio. This PR changes the album grid from this:

Screen Shot 2020-11-22 at 11 10 15 AM

To this:

Screen Shot 2020-11-22 at 11 09 37 AM

(Also, this is my very first commit to a golang project, and I don't actually know any golang, so apologies if there was a much easier way to do this. :)

@deluan
Copy link
Member

deluan commented Nov 22, 2020

Great!! This fixes issue #496.

I took the liberty to add a commit to also fix this in the album show view. I also changed the object-fit property to match the CSS-in-JS style (objectFit)

@deluan deluan merged commit a89afb5 into navidrome:master Nov 22, 2020
@jwalton jwalton deleted the fix-aspect-ratio branch November 22, 2020 21:25
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants