New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch linting from pylint to ruff #1345

Open

2 of 9 tasks

wakamex opened this issue Mar 5, 2024 · 3 comments

Contributor

wakamex commented Mar 5, 2024 •

edited

Loading

pylint feature parity is tracked here astral-sh/ruff#970.

the biggest missing feature set seems to be lack of docstring linting.

out of the unimplemented errors, the ones I recognize are:

function-redefined
import-error
no-member
too-many-function-args

warnings I recognize:

arguments-differ
attribute-defined-outside-init
missing docstring (multiple)
pointless-string-statement (I use this as in-script documentation lol)
redefined-outer-name

Member

dpaiton commented Jun 5, 2024 •

edited

Loading

on hold until ruff supports docstring linting

Contributor Author

wakamex commented Jun 5, 2024 •

edited

Loading

Implemented since my last review:

function-redefined
missing-class-docstring / C0115 (D101)
missing-function-docstring / C0116 (D103)
missing-module-docstring / C0114 (D100)

Still not implemented

import-error
no-member
too-many-function-args
arguments-differ (warning)
attribute-defined-outside-init (warning)
redefined-outer-name (warning)

If we don't think the unimplemented ones above (or any I missed) I'd be happy switching to ruff from pylint @dpaiton @slundqui

Member

dpaiton commented Jun 11, 2024

I think we still want

import-error
no-member
arguments-differ (warning)
redefined-outer-name (warning)

IMO the other two are nice-to-have but not required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment