New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the units in `collectGovernanceFee` #668

Closed

jalextowle opened this issue Nov 11, 2023 · 0 comments · Fixed by #671

Assignees

Contributor

jalextowle commented Nov 11, 2023

I just realized that this comment isn't correct. It's going to return proceeds in whatever options specifies. We probably need to use the _convertFromOptionToBase() on proceeds before it is emitted in CollectGovernanceFee()and returned

jalextowle mentioned this issue

Improved Proxy Architecture #654

Merged

jrhea self-assigned this

jrhea mentioned this issue

ensure the event emits amount in units of base #671

Merged

jrhea closed this as completed in #671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment