Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make recognition interval and number of threads external parameters #6

Closed
denis-stepanov opened this issue Aug 8, 2022 · 0 comments · Fixed by #25
Closed

Make recognition interval and number of threads external parameters #6

denis-stepanov opened this issue Aug 8, 2022 · 0 comments · Fixed by #25
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@denis-stepanov
Copy link
Owner

Currently the parameters are the interval (called SECONDS in advent.py) and the offset between threads (called OFFSET). It makes sense to make offset calculable and specify a number of threads instead (default should be function of the interval), which is a bit more intuitive for a user. Safeguards shall be put in place to avoid division by zero or some unrealistic configurations (like running many more threads than CPU cores available).

@denis-stepanov denis-stepanov added the enhancement New feature or request label Aug 8, 2022
@denis-stepanov denis-stepanov added this to the v1.2.0 milestone Aug 17, 2022
@denis-stepanov denis-stepanov self-assigned this Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant