From 1e7babaecad3686ab4ba4abe6e8906cd433d537f Mon Sep 17 00:00:00 2001
From: ingalless <jonathanaingall@gmail.com>
Date: Tue, 10 Dec 2024 22:41:24 +0000
Subject: [PATCH] chore(tests): Deprecate remaining usages of itest in check
 tests (#26962)

This PR progresses #22907 by deprecating the usage of `itest` in
`tests/integration/check_tests.rs`
---
 tests/integration/check_tests.rs                   | 14 --------------
 tests/specs/check/check_all/__test__.jsonc         |  5 +++++
 .../all => specs/check/check_all}/check_all.out    |  0
 .../all => specs/check/check_all}/check_all.ts     |  0
 tests/specs/check/check_all_local/__test__.jsonc   |  5 +++++
 .../specs/check/check_all_local/check_all_local.ts |  3 +++
 tools/lint.js                                      |  2 +-
 7 files changed, 14 insertions(+), 15 deletions(-)
 create mode 100644 tests/specs/check/check_all/__test__.jsonc
 rename tests/{testdata/check/all => specs/check/check_all}/check_all.out (100%)
 rename tests/{testdata/check/all => specs/check/check_all}/check_all.ts (100%)
 create mode 100644 tests/specs/check/check_all_local/__test__.jsonc
 create mode 100644 tests/specs/check/check_all_local/check_all_local.ts

diff --git a/tests/integration/check_tests.rs b/tests/integration/check_tests.rs
index 178ac6493f0cb5..b98d719fcaa303 100644
--- a/tests/integration/check_tests.rs
+++ b/tests/integration/check_tests.rs
@@ -3,23 +3,9 @@
 use deno_lockfile::NewLockfileOptions;
 use deno_semver::jsr::JsrDepPackageReq;
 use test_util as util;
-use test_util::itest;
 use util::TestContext;
 use util::TestContextBuilder;
 
-itest!(check_all {
-  args: "check --allow-import --quiet --all check/all/check_all.ts",
-  output: "check/all/check_all.out",
-  http_server: true,
-  exit_code: 1,
-});
-
-itest!(check_all_local {
-  args: "check --allow-import --quiet check/all/check_all.ts",
-  output_str: Some(""),
-  http_server: true,
-});
-
 #[test]
 fn cache_switching_config_then_no_config() {
   let context = TestContext::default();
diff --git a/tests/specs/check/check_all/__test__.jsonc b/tests/specs/check/check_all/__test__.jsonc
new file mode 100644
index 00000000000000..101e5aab9e8cec
--- /dev/null
+++ b/tests/specs/check/check_all/__test__.jsonc
@@ -0,0 +1,5 @@
+{
+  "args": "check --allow-import --quiet --all check_all.ts",
+  "output": "check_all.out",
+  "exitCode": 1
+}
diff --git a/tests/testdata/check/all/check_all.out b/tests/specs/check/check_all/check_all.out
similarity index 100%
rename from tests/testdata/check/all/check_all.out
rename to tests/specs/check/check_all/check_all.out
diff --git a/tests/testdata/check/all/check_all.ts b/tests/specs/check/check_all/check_all.ts
similarity index 100%
rename from tests/testdata/check/all/check_all.ts
rename to tests/specs/check/check_all/check_all.ts
diff --git a/tests/specs/check/check_all_local/__test__.jsonc b/tests/specs/check/check_all_local/__test__.jsonc
new file mode 100644
index 00000000000000..0cd1c16acb1d54
--- /dev/null
+++ b/tests/specs/check/check_all_local/__test__.jsonc
@@ -0,0 +1,5 @@
+{
+  "args": "check --allow-import --quiet check_all_local.ts",
+  "output": "",
+  "exitCode": 0
+}
diff --git a/tests/specs/check/check_all_local/check_all_local.ts b/tests/specs/check/check_all_local/check_all_local.ts
new file mode 100644
index 00000000000000..2ae8c2692cc20c
--- /dev/null
+++ b/tests/specs/check/check_all_local/check_all_local.ts
@@ -0,0 +1,3 @@
+import * as a from "http://localhost:4545/subdir/type_error.ts";
+
+console.log(a.a);
diff --git a/tools/lint.js b/tools/lint.js
index 2312cde272580e..5bc3f2654fd012 100755
--- a/tools/lint.js
+++ b/tools/lint.js
@@ -211,7 +211,7 @@ async function ensureNoNewITests() {
     "bench_tests.rs": 0,
     "cache_tests.rs": 0,
     "cert_tests.rs": 0,
-    "check_tests.rs": 2,
+    "check_tests.rs": 0,
     "compile_tests.rs": 0,
     "coverage_tests.rs": 0,
     "eval_tests.rs": 0,