Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copyN in std/io/ioutil.ts should be (src, dst) rather than (dst, src) to match Deno.copy #4896

Closed
ry opened this issue Apr 25, 2020 · 2 comments
Closed

copyN in std/io/ioutil.ts should be (src, dst) rather than (dst, src) to match Deno.copy #4896

ry opened this issue Apr 25, 2020 · 2 comments
Labels
good first issue Good for newcomers

Comments

@ry
Copy link
Member

ry commented Apr 25, 2020

We recently changed the order of the arguments
0cb1bb9

copyN (and potentially other functions) should use the same convention.

This may effect #4865 if it's done before that lands.
@ry ry added the good first issue Good for newcomers label Apr 25, 2020
@akshatagarwl
Copy link
Contributor

I'll do it

@akshatagarwl akshatagarwl mentioned this issue Apr 25, 2020
Merged
@trivikr
Copy link
Contributor

trivikr commented Apr 26, 2020 •
edited
Loading

Fixed in #4900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ry @bartlomieju @trivikr @akshatagarwl