Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swc_ecmascript #37

Closed
nayeemrmn opened this issue Nov 18, 2021 · 6 comments · Fixed by #39
Closed

Update swc_ecmascript #37

nayeemrmn opened this issue Nov 18, 2021 · 6 comments · Fixed by #39
Assignees
Labels
enhancement New feature or request

Comments

@nayeemrmn
Copy link

nayeemrmn commented Nov 18, 2021

denoland/deno#10861 and denoland/deno#12532 have been fixed by swc-project/swc#2530, but swc_ecmascript hasn't been updated in a while.

cc @dsherret

@kitsonk
Copy link
Contributor

kitsonk commented Nov 18, 2021

See: denoland/deno#12565 (comment)

@dsherret
Copy link
Member

dsherret commented Nov 18, 2021

Not sure how to fix this one... we're blocked on this.

Building deno...
    Updating crates.io index
error: failed to select a version for `indexmap`.
    ... required by package `swc_fast_graph v0.1.0`
    ... which satisfies dependency `swc_fast_graph = "^0.1"` of package `swc_bundler v0.82.0`
    ... which satisfies dependency `swc_bundler = "^0.82.0"` of package `deno_ast v0.6.0 (V:\deno_ast)`
    ... which satisfies path dependency `deno_ast` of package `deno v1.16.2 (V:\deno\cli)`
versions that meet the requirements `^1.7.0` are: 1.7.0

all possible versions conflict with previously selected packages.

  previously selected package `indexmap v1.6.2`
    ... which satisfies dependency `indexmap = "=1.6.2"` of package `deno_core v0.108.0 (V:\deno\core)`
    ... which satisfies path dependency `deno_core` of package `deno v1.16.2 (V:\deno\cli)`

failed to select a version for `indexmap` which could resolve this conflict

@bartlomieju
Copy link
Member

bartlomieju commented Nov 18, 2021

I think we have to ask SWC to pin to indexmap =1.6.2 for the time being.

@dsherret
Copy link
Member

It seems we can just upgrade to 1.7.0. Everything seems to work when I try that. We'll just have to update the import_map crate.

@dsherret
Copy link
Member

Somewhat blocked on swc-project/swc#2801

@dsherret
Copy link
Member

dsherret commented Nov 19, 2021

Opened swc-project/swc#2808 -- Right now the REPL is broken because names are getting renamed. If we can't get this working with SWC then maybe we can use the TS compiler instead (which wouldn't be so bad for the repl)

Edit: We should also wait on this one swc-project/swc#2802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants