feat(node): Basic support for child_process.spawn

[uki00a]

Summary

This PR adds basic support for child_process.spawn based on the Deno.run API.

Related to denoland/deno#5376

Limitation

Currently, support for the shell option in Windows is quite limited due to escaping issues. For more details, see the following issues:

• Command does not escape arguments as expected on windows rust-lang/rust#29494
• The quotation in cmd of Deno.run deno#8852

[CLAassistant]

All committers have signed the CLA.

[kt3k]

👍

[kt3k]

@uki00a What do you think is the remaining task for the first pass?

[uki00a]

@kt3k I'm still having one problem and not sure yet if that problem is caused by this PR's code or by the Deno.run API. 🤔

What is the problem?

There is a test.ts with the following contents:

import { spawn } from "./node/child_process.ts"

const deno = spawn("deno", ["--version"]);
let out = "";
deno.stdout!.on("data", (chunk) => {
  out += chunk;
});
deno.stderr!.on("data", (err) => console.error(err));
deno.on("exit", () => {
  console.log(out);
});

When I run this file, it works as intended:

$ deno run -A --unstable test.ts

deno 1.8.3 (release, x86_64-unknown-linux-gnu)
v8 9.0.257.3
typescript 4.2.2

Then, change the test.ts as follows:

import { spawn } from "./node/child_process.ts"

const git = spawn("git", ["--version"]);
let out = "";
git.stdout!.on("data", (chunk) => {
  out += chunk;
});
git.stderr!.on("data", (err) => console.error(err));
git.on("exit", () => {
  console.log(out);
});

When I run the test.ts, I get the following errors:

$ deno run -A --unstable test.ts

Uncaught Interrupted: operation canceled
Uncaught Interrupted: operation canceled

[uki00a]

The problem causing the "operation canceled" error has been resolved by 9e38473. However, tests for the canary build seem to be failing... 🤔🧐

error: TS2322 [ERROR]: Type '{ transport: string; hostname: string; port: number; }' is not assignable to type 'Addr'.
  Object literal may only specify known properties, and 'hostname' does not exist in type 'Addr'.
      hostname: "",
      ~~~~~~~~~~~~
    at file:///Users/runner/work/deno_std/deno_std/http/_mock_conn.ts:8:7

[kt3k]

Canary test is failing because of #860, and probably will be fixed by #861. No need of actions for now.

[kt3k]

@uki00a Nice work! Thanks!

LGTM

[uki00a]

Thanks!