Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawning async task and then exiting causes spawned process to not be killed #132

Closed
dsherret opened this issue Nov 28, 2024 · 2 comments
Closed

Comments

@dsherret
Copy link
Member

dsherret commented Nov 28, 2024

Another case when spawned process not closed when deno task exit

{
  "importMap": "./import_map.json",
  "tasks": {
    "lume": "echo \"import 'lume/task.ts'\" | deno run --unstable --allow-read --allow-run --lock=lock.json -",
    "serve": "deno task lume -s",
    "test": "deno task serve --quiet & PUPPETEER_PRODUCT=chrome deno test --no-check --parallel --shuffle=7 --unstable --allow-env --allow-write --allow-read --allow-net --allow-run ; exit"
  }
}

This is my deno.json config for running e2e test.
In this example when I run deno task test, the server is still running although the deno test is done.
(notice there is ; exit at the end of line)

Originally posted by @DrSensor in #33 (comment)

@dsherret
Copy link
Member Author

@DrSensor I think this issue is fixed? I'm not able to reproduce it

@dsherret
Copy link
Member Author

dsherret commented Dec 4, 2024

Going to close this one. Let me know if this is still an issue once Deno 2.1.3 is released.

@dsherret dsherret closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant