Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: show number of comments of an item on the main page next to the timestamp #209

Closed
brunocorrea23 opened this issue May 18, 2023 · 5 comments
Closed

proposal: show number of comments of an item on the main page next to the timestamp #209

brunocorrea23 opened this issue May 18, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@brunocorrea23
Copy link
Contributor

Similar to what Hacker News does (https://news.ycombinator.com/)
Screenshot 2023-05-18 at 15 56 20
@brunocorrea23 brunocorrea23 added the enhancement New feature or request label May 18, 2023
@iuioiua
Copy link
Contributor

iuioiua commented May 18, 2023

We previously had comment counts but removed them in #171 because it wasn't worth the added complexity and overhead. However, if Deno.Kv.count() is implemented, it'll be worth considering adding this feature back in.

@lino-levan
Copy link
Contributor

@iuioiua would you be willing to bring this back via an index? Something like a cached comment count on the post object itself?

@iuioiua
Copy link
Contributor

iuioiua commented Jun 22, 2023

Slightly likely not. However, I'd be happy to consider a PR that does this without incurring too much of a complexity cost.

@roberto-morado roberto-morado mentioned this issue Jul 11, 2023
Closed
@iuioiua iuioiua added the v1 label Jul 18, 2023
@iuioiua
Copy link
Contributor

iuioiua commented Aug 31, 2023

It seems this feature would incur a similar complexity cost that voting functionality has incurred on item logic, which has been a bit of a pain point for the codebase, IMO. For that reason, I'd rather not have this feature. WDYT, @brunocorrea23?

@iuioiua iuioiua removed the v1 label Sep 1, 2023
@iuioiua
Copy link
Contributor

iuioiua commented Sep 7, 2023

Gently pinging @brunocorrea23.

@iuioiua iuioiua closed this as not planned Won't fix, can't repro, duplicate, stale Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: rating algorithm
3 participants
@brunocorrea23 @lino-levan @iuioiua