Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assertNotEquals assertion error message discrepancy #4955

Closed
se-u opened this issue Jun 4, 2024 · 2 comments · Fixed by #6246
Closed

assertNotEquals assertion error message discrepancy #4955

se-u opened this issue Jun 4, 2024 · 2 comments · Fixed by #6246
Assignees
Labels
bug Something isn't working needs triage

Comments

@se-u
Copy link

se-u commented Jun 4, 2024

There is an issue with the assertNotEquals output int the current version of the library. The assertion error message does not reflect the expected string values accurately. Specifically, the following test case:

assertNotEquals('1','1');

is expected to throw an error with the message:

AssertionError: Expected actual: '1' not to be: '1'.

However, the current output is:
AssertionError: Expected actual: 1 not to be: 1.

Environment

  • OS: MacOS 12
  • deno version: 1.44.0
  • std version: 0.226.0
@se-u se-u added bug Something isn't working needs triage labels Jun 4, 2024
@iuioiua
Copy link
Contributor

iuioiua commented Jun 5, 2024

I'm happy to add quotes to strings for this function. WDYT, @kt3k?

@kt3k
Copy link
Member

kt3k commented Jun 5, 2024

The suggestion makes sense to me. Maybe we should use format of std/internal to make the expression?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants