Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: change @std/archive to @std/tar #5733

Closed
BlackAsLight opened this issue Aug 20, 2024 · 3 comments · Fixed by #5905
Closed

Proposal: change @std/archive to @std/tar #5733

BlackAsLight opened this issue Aug 20, 2024 · 3 comments · Fixed by #5905
Labels

Comments

@BlackAsLight
Copy link
Contributor

BlackAsLight commented Aug 20, 2024

As it stands, @std/archive only contains one type of archive format, Tar. This proposal suggests that it should be renamed to its own @std module for the following reasons:

  1. The std currently supports many file formats and all of them, with the exception of Tar, have their own module. They are named after said file format instead of by category of format. It makes no sense for Tar to be treated differently than these other file formats.
    • @std/csv
    • @std/dotenv
    • @std/ini
    • @std/json
    • @std/jsonc
    • @std/msgpack
    • @std/toml
    • @std/yaml
  2. While there are many archive formats, many of them also double as file compression formats, and some file formats only offer compression. Assuming both @std/archive and @std/compress existed, how would a file format that supported both be categorised?
@iuioiua
Copy link
Contributor

iuioiua commented Aug 20, 2024

These are fair points. I'm open to having #4548 be implemented in a new @std/tar package. Though, let's wait to hear other's thoughts.

@iuioiua iuioiua added feedback welcome We want community's feedback on this issue or PR archive labels Aug 20, 2024
@iuioiua
Copy link
Contributor

iuioiua commented Aug 20, 2024

WDYT, @kt3k?

@iuioiua
Copy link
Contributor

iuioiua commented Sep 4, 2024

We're in agreement for this change. PR coming shortly.

@iuioiua iuioiua removed the feedback welcome We want community's feedback on this issue or PR label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants