From eca9c0f17bdecaee68b5c0b4898efdc8bcfdb046 Mon Sep 17 00:00:00 2001 From: Yoshiya Hinosawa Date: Wed, 10 Apr 2024 12:09:22 +0900 Subject: [PATCH 1/4] deprecation(semver): deprecate rangeMax and rangeMin --- semver/range_max.ts | 2 ++ semver/range_min.ts | 2 ++ 2 files changed, 4 insertions(+) diff --git a/semver/range_max.ts b/semver/range_max.ts index eef7d745172f..a66b8f125d1c 100644 --- a/semver/range_max.ts +++ b/semver/range_max.ts @@ -44,6 +44,8 @@ function comparatorMax(comparator: Comparator): SemVer { } /** + * @deprecated (will be removed in 1.0.0) use greaterThanRange or lessThanRange for comparing ranges and semvers. + * * The maximum valid SemVer for a given range or INVALID * @param range The range to calculate the max for * @returns A valid SemVer or INVALID diff --git a/semver/range_min.ts b/semver/range_min.ts index 9a09aafb4307..3935063b1c62 100644 --- a/semver/range_min.ts +++ b/semver/range_min.ts @@ -35,6 +35,8 @@ function comparatorMin(comparator: Comparator): SemVer { } /** + * @deprecated (will be removed in 1.0.0) use greaterThanRange or lessThanRange for comparing ranges and semvers. + * * The minimum valid SemVer for a given range or INVALID * @param range The range to calculate the min for * @returns A valid SemVer or INVALID From 57490b0f4ccafbf4ab76bc58d807f10bed4a228c Mon Sep 17 00:00:00 2001 From: Yoshiya Hinosawa Date: Wed, 10 Apr 2024 12:17:37 +0900 Subject: [PATCH 2/4] add docs --- semver/range_max.ts | 2 +- semver/range_min.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/semver/range_max.ts b/semver/range_max.ts index a66b8f125d1c..7190e7c2f7a8 100644 --- a/semver/range_max.ts +++ b/semver/range_max.ts @@ -44,7 +44,7 @@ function comparatorMax(comparator: Comparator): SemVer { } /** - * @deprecated (will be removed in 1.0.0) use greaterThanRange or lessThanRange for comparing ranges and semvers. + * @deprecated (will be removed in 1.0.0) use greaterThanRange or lessThanRange for comparing ranges and semvers. The maximum version of a range is often not well defined, and therefore this API shouldn't be used. See https://github.com/denoland/deno_std/issues/4365 for details. * * The maximum valid SemVer for a given range or INVALID * @param range The range to calculate the max for diff --git a/semver/range_min.ts b/semver/range_min.ts index 3935063b1c62..fdcad1cebe42 100644 --- a/semver/range_min.ts +++ b/semver/range_min.ts @@ -35,7 +35,7 @@ function comparatorMin(comparator: Comparator): SemVer { } /** - * @deprecated (will be removed in 1.0.0) use greaterThanRange or lessThanRange for comparing ranges and semvers. + * @deprecated (will be removed in 1.0.0) use greaterThanRange or lessThanRange for comparing ranges and semvers. The minimum version of a range is often not well defined, and therefore this API shouldn't be used. See https://github.com/denoland/deno_std/issues/4365 for details. * * The minimum valid SemVer for a given range or INVALID * @param range The range to calculate the min for From 02929408b81aa4ec027a06314186c8ebf8de2cfe Mon Sep 17 00:00:00 2001 From: Yoshiya Hinosawa Date: Wed, 10 Apr 2024 12:19:50 +0900 Subject: [PATCH 3/4] add links --- semver/range_max.ts | 2 +- semver/range_min.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/semver/range_max.ts b/semver/range_max.ts index 7190e7c2f7a8..c66a362ecd8d 100644 --- a/semver/range_max.ts +++ b/semver/range_max.ts @@ -44,7 +44,7 @@ function comparatorMax(comparator: Comparator): SemVer { } /** - * @deprecated (will be removed in 1.0.0) use greaterThanRange or lessThanRange for comparing ranges and semvers. The maximum version of a range is often not well defined, and therefore this API shouldn't be used. See https://github.com/denoland/deno_std/issues/4365 for details. + * @deprecated (will be removed in 1.0.0) Use {@linkcode greaterThanRange} or {@linkcode lessThanRange} for comparing ranges and semvers. The maximum version of a range is often not well defined, and therefore this API shouldn't be used. See https://github.com/denoland/deno_std/issues/4365 for details. * * The maximum valid SemVer for a given range or INVALID * @param range The range to calculate the max for diff --git a/semver/range_min.ts b/semver/range_min.ts index fdcad1cebe42..d7ab85384a5f 100644 --- a/semver/range_min.ts +++ b/semver/range_min.ts @@ -35,7 +35,7 @@ function comparatorMin(comparator: Comparator): SemVer { } /** - * @deprecated (will be removed in 1.0.0) use greaterThanRange or lessThanRange for comparing ranges and semvers. The minimum version of a range is often not well defined, and therefore this API shouldn't be used. See https://github.com/denoland/deno_std/issues/4365 for details. + * @deprecated (will be removed in 1.0.0) Use {@linkcode greaterThanRange} or {@linkcode lessThanRange} for comparing ranges and semvers. The minimum version of a range is often not well defined, and therefore this API shouldn't be used. See https://github.com/denoland/deno_std/issues/4365 for details. * * The minimum valid SemVer for a given range or INVALID * @param range The range to calculate the min for From 65c1b9573f00f8d47c768ca4a0c223b565d67a7f Mon Sep 17 00:00:00 2001 From: Asher Gomez Date: Wed, 10 Apr 2024 13:53:37 +1000 Subject: [PATCH 4/4] tweaks --- semver/range_max.ts | 6 +++++- semver/range_min.ts | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/semver/range_max.ts b/semver/range_max.ts index c66a362ecd8d..8f6340671935 100644 --- a/semver/range_max.ts +++ b/semver/range_max.ts @@ -44,7 +44,11 @@ function comparatorMax(comparator: Comparator): SemVer { } /** - * @deprecated (will be removed in 1.0.0) Use {@linkcode greaterThanRange} or {@linkcode lessThanRange} for comparing ranges and semvers. The maximum version of a range is often not well defined, and therefore this API shouldn't be used. See https://github.com/denoland/deno_std/issues/4365 for details. + * @deprecated (will be removed in 1.0.0) Use {@linkcode greaterThanRange} or + * {@linkcode lessThanRange} for comparing ranges and semvers. The maximum + * version of a range is often not well defined, and therefore this API + * shouldn't be used. See + * {@link https://github.com/denoland/deno_std/issues/4365} for details. * * The maximum valid SemVer for a given range or INVALID * @param range The range to calculate the max for diff --git a/semver/range_min.ts b/semver/range_min.ts index d7ab85384a5f..497e7fd63315 100644 --- a/semver/range_min.ts +++ b/semver/range_min.ts @@ -35,7 +35,11 @@ function comparatorMin(comparator: Comparator): SemVer { } /** - * @deprecated (will be removed in 1.0.0) Use {@linkcode greaterThanRange} or {@linkcode lessThanRange} for comparing ranges and semvers. The minimum version of a range is often not well defined, and therefore this API shouldn't be used. See https://github.com/denoland/deno_std/issues/4365 for details. + * @deprecated (will be removed in 1.0.0) Use {@linkcode greaterThanRange} or + * {@linkcode lessThanRange} for comparing ranges and semvers. The minimum + * version of a range is often not well defined, and therefore this API + * shouldn't be used. See + * {@link https://github.com/denoland/deno_std/issues/4365} for details. * * The minimum valid SemVer for a given range or INVALID * @param range The range to calculate the min for