-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(streams/unstable): toLines()
#5121
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5121 +/- ##
=======================================
Coverage 96.25% 96.25%
=======================================
Files 475 476 +1
Lines 38464 38475 +11
Branches 5584 5584
=======================================
+ Hits 37023 37034 +11
Misses 1399 1399
Partials 42 42 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! However, I'm still skeptical about whether this provides sufficient value to justify having it in the Standard Library (weak opinion).
Since this is effectively a functional |
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
- Change the return type from `AsyncGenerator<string>` to `ReadableStream<string>` - Change `readable` to only be of type `ReadableStream<Uint8Array>` - Add `options` argument of type `PipeOptions.`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few tweaks. Now, LGTM.
Closes #5071
Signature:
toLines(readable: ReadableStream<Uint8Array>): ReadableStream<string>
Usage