Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(http): release http@1.0.0 #5217

Merged
merged 5 commits into from
Jul 30, 2024
Merged

chore(http): release http@1.0.0 #5217

merged 5 commits into from
Jul 30, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jul 1, 2024

To be merged July 25.

The latest API docs: https://jsr.io/@std/http@1.0.0-rc.6/doc

Closes #5007

@iuioiua iuioiua requested a review from kt3k as a code owner July 1, 2024 03:58
@github-actions github-actions bot added the http label Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (7fd14ba) to head (12fcba2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5217   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files         465      465           
  Lines       37766    37766           
  Branches     5580     5580           
=======================================
  Hits        36439    36439           
  Misses       1285     1285           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k requested a review from bartlomieju July 16, 2024 12:10
@bartlomieju
Copy link
Member

Do we expect to stabilize parseSignedCookie and signCookie before merging this one?

@iuioiua
Copy link
Contributor Author

iuioiua commented Jul 17, 2024

No, we're keeping them unstable until they've lived around long enough and until #5257 is resolved.

@iuioiua
Copy link
Contributor Author

iuioiua commented Jul 25, 2024

@kt3k, please provide final review.

@kt3k
Copy link
Member

kt3k commented Jul 29, 2024

eTag return type can be Promise<string> for string and Uint8Array inputs. Not sure worth the breaking change though..

@iuioiua
Copy link
Contributor Author

iuioiua commented Jul 29, 2024

Can you create PR so we can get a better idea of what you mean?

@iuioiua
Copy link
Contributor Author

iuioiua commented Jul 30, 2024

Good to merge now, @kt3k?

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit c77e966 into main Jul 30, 2024
13 checks passed
@iuioiua iuioiua deleted the http-1 branch July 30, 2024 03:28
@kt3k
Copy link
Member

kt3k commented Jul 30, 2024

but I'll also suggest removing ETagResource symbol, as it's not referenced from public API anymore.

@iuioiua
Copy link
Contributor Author

iuioiua commented Jul 30, 2024

SGTM

@iuioiua
Copy link
Contributor Author

iuioiua commented Aug 1, 2024

I suggest renaming STATUS_CODE to STATUS_CODES (with an "s" suffix) and STATUS_TEXT to STATUS_TEXTS (also with an "s" suffix).

@kt3k
Copy link
Member

kt3k commented Aug 1, 2024

I suggest renaming STATUS_CODE to STATUS_CODES (with an "s" suffix) and STATUS_TEXT to STATUS_TEXTS (also with an "s" suffix).

I'm not in favor of that change. Why do we need it?

It feels like a bit too late to start discussing that kind of idea.

@iuioiua
Copy link
Contributor Author

iuioiua commented Aug 1, 2024

Well, the name doesn't make sense. The object is not a "status code". Rather, it's an object whose entries are status codes. Same for "status text". The only reason we'd keep it is to avoid disruption, but we'd be settling for something that's incorrect. Plus, it's a very trivial change.

@iuioiua
Copy link
Contributor Author

iuioiua commented Aug 1, 2024

For context, node:http has STATUS_CODES and METHODS, which are also objects. Changing to the wrong name was made in #3781 by me.

@kt3k
Copy link
Member

kt3k commented Aug 1, 2024

These can be seen as equivalent of TypeScript enums, and enums are usually named in singular form. https://www.typescriptlang.org/docs/handbook/enums.html

@iuioiua
Copy link
Contributor Author

iuioiua commented Aug 1, 2024

That seems like an obscure reason for the name. Again, it's an object whose entries are status codes. It itself, is not actually a status code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stabilize @std/http
3 participants