-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(http): release http@1.0.0
#5217
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5217 +/- ##
=======================================
Coverage 96.48% 96.48%
=======================================
Files 465 465
Lines 37766 37766
Branches 5580 5580
=======================================
Hits 36439 36439
Misses 1285 1285
Partials 42 42 ☔ View full report in Codecov by Sentry. |
Do we expect to stabilize |
No, we're keeping them unstable until they've lived around long enough and until #5257 is resolved. |
@kt3k, please provide final review. |
|
Can you create PR so we can get a better idea of what you mean? |
Good to merge now, @kt3k? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
but I'll also suggest removing |
SGTM |
I suggest renaming |
I'm not in favor of that change. Why do we need it? It feels like a bit too late to start discussing that kind of idea. |
Well, the name doesn't make sense. The object is not a "status code". Rather, it's an object whose entries are status codes. Same for "status text". The only reason we'd keep it is to avoid disruption, but we'd be settling for something that's incorrect. Plus, it's a very trivial change. |
For context, |
These can be seen as equivalent of TypeScript enums, and enums are usually named in singular form. https://www.typescriptlang.org/docs/handbook/enums.html |
That seems like an obscure reason for the name. Again, it's an object whose entries are status codes. It itself, is not actually a status code. |
To be merged July 25.
The latest API docs: https://jsr.io/@std/http@1.0.0-rc.6/doc
Closes #5007