Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(yaml): add check of merge of list of mapping #5496

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jul 20, 2024

This PR adds the check of merge of list of mapping. (Reduces 8 missed lines in yaml/_loader.ts coverage report)

@github-actions github-actions bot added the yaml label Jul 20, 2024
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.30%. Comparing base (3ee4c4d) to head (c5c1f36).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5496      +/-   ##
==========================================
+ Coverage   96.27%   96.30%   +0.02%     
==========================================
  Files         463      463              
  Lines       37660    37660              
  Branches     5556     5558       +2     
==========================================
+ Hits        36257    36267      +10     
+ Misses       1361     1351      -10     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@kt3k kt3k merged commit c3ccd67 into denoland:main Jul 20, 2024
16 checks passed
@kt3k kt3k deleted the test-yaml-merge-list-of-obj branch July 20, 2024 10:02
@kt3k kt3k restored the test-yaml-merge-list-of-obj branch July 20, 2024 10:03
@kt3k kt3k deleted the test-yaml-merge-list-of-obj branch July 20, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants