fix(assert): assertObjectMatch doesn't print whole object
#5498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5498 +/- ##
=======================================
Coverage 96.30% 96.30%
=======================================
Files 463 463
Lines 37660 37669 +9
Branches 5558 5561 +3
=======================================
+ Hits 36267 36276 +9
Misses 1351 1351
Partials 42 42 ☔ View full report in Codecov by Sentry. |
iuioiua
approved these changes
Jul 21, 2024
|
|
||
| // When both operands are set, build a filtered set with common values | ||
| if ((value instanceof Set) && (subset instanceof Set)) { | ||
| filtered[key] = value.intersection(subset); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated from #5408
Fix: #3771
When filtering two objects, the
fn()function returns an empty object if they don't have the same keys or symbols. This PR adds the logic so that it returns the entries of the first object in this case. (also renamefntofilterObject)