Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation(url): deprecate @std/url #5530

Merged
merged 5 commits into from
Aug 2, 2024
Merged

deprecation(url): deprecate @std/url #5530

merged 5 commits into from
Aug 2, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jul 24, 2024

What's changed

@std/url has been deprecated in favor of the following @std/path/posix corresponding functions:

  1. basename()
  2. dirname()
  3. extname()
  4. join()
  5. normalize()

Motivation

This change was made as @std/path/posix functions essentially do the same jobs as those in @std/url. @std/url will be soon be removed, but as JSR is immutable, the last version of the package to live on with all functionality intact, but noted as deprecated.

Migration guide

To migrate, please see the latest documentation for the following functions for examples on how to use URLs:

  1. basename()
  2. dirname()
  3. extname()
  4. join()
  5. normalize()

Related

Addresses #4992 (review)

@iuioiua iuioiua requested a review from kt3k as a code owner July 24, 2024 01:27
@iuioiua iuioiua enabled auto-merge (squash) July 24, 2024 01:27
@github-actions github-actions bot added the url label Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.37%. Comparing base (0d30f02) to head (40d6aa1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5530   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files         466      466           
  Lines       37571    37571           
  Branches     5538     5538           
=======================================
  Hits        36210    36210           
  Misses       1319     1319           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua disabled auto-merge July 26, 2024 05:49
@iuioiua
Copy link
Contributor Author

iuioiua commented Aug 1, 2024

@kt3k, are you sure #5537 is a blocker for this? I don't think it is because we already have the appropriate instructions needed thanks to #5371. I think we can make these moves asynchronously.

@kt3k
Copy link
Member

kt3k commented Aug 2, 2024

Ok. Let's first deprecate the package.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua changed the title chore(url): deprecate @std/url deprecation(url): deprecate @std/url Aug 2, 2024
@iuioiua iuioiua merged commit 3f13395 into main Aug 2, 2024
15 checks passed
@iuioiua iuioiua deleted the deprecate-std-url branch August 2, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants