-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecation(url): deprecate @std/url
#5530
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5530 +/- ##
=======================================
Coverage 96.37% 96.37%
=======================================
Files 466 466
Lines 37571 37571
Branches 5538 5538
=======================================
Hits 36210 36210
Misses 1319 1319
Partials 42 42 ☔ View full report in Codecov by Sentry. |
Ok. Let's first deprecate the package. |
kt3k
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
iuioiua
changed the title
chore(url): deprecate
deprecation(url): deprecate Aug 2, 2024
@std/url
@std/url
This was referenced Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed
@std/url
has been deprecated in favor of the following@std/path/posix
corresponding functions:basename()
dirname()
extname()
join()
normalize()
Motivation
This change was made as
@std/path/posix
functions essentially do the same jobs as those in@std/url
.@std/url
will be soon be removed, but as JSR is immutable, the last version of the package to live on with all functionality intact, but noted as deprecated.Migration guide
To migrate, please see the latest documentation for the following functions for examples on how to use URLs:
basename()
dirname()
extname()
join()
normalize()
Related
Addresses #4992 (review)