test(cli): stop spinner without error #5551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5551 +/- ##
=======================================
Coverage 96.48% 96.48%
=======================================
Files 465 465
Lines 37772 37772
Branches 5580 5580
=======================================
Hits 36445 36445
Misses 1285 1285
Partials 42 42 ☔ View full report in Codecov by Sentry. |
iuioiua
reviewed
Jul 26, 2024
iuioiua
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently most spinner test scripts end the execution with errors (because
setTimeout(spinner.stop, num)throws instead of correctly stopping the spinner).This PR fixes them by correctly stopping the spinners.
(This probably fixes #5541 )