fix(semver): throw on invalid input in parseRange()
#5567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
commented
Jul 29, 2024
| import { isSemVer } from "./is_semver.ts"; | ||
|
|
||
| function isComparator(value: unknown): value is Comparator { | ||
| if ( | ||
| value === null || value === undefined || Array.isArray(value) || | ||
| typeof value !== "object" | ||
| ) return false; | ||
| if (value === NONE || value === ALL) return true; | ||
| if (value === ALL) return true; |
There was a problem hiding this comment.
Here, we no longer regard <0.0.0 as a valid comparator.
semver/parse_range.ts
Outdated
| // remove spaces between operators and versions | ||
| .replaceAll(/(?<=<|>|=|~) +/g, "") | ||
| .replaceAll(/(?<=<|>|=|~)(\s+)/g, "") |
There was a problem hiding this comment.
Pass-by fix that this change requires.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5567 +/- ##
==========================================
+ Coverage 96.12% 96.48% +0.36%
==========================================
Files 465 465
Lines 37772 37770 -2
Branches 5549 5582 +33
==========================================
+ Hits 36308 36443 +135
+ Misses 1422 1285 -137
Partials 42 42 ☔ View full report in Codecov by Sentry. |
iuioiua
commented
Jul 29, 2024
kt3k
reviewed
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4845