Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(assert): mark options argument of AssertionError constructor unstable #5573

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jul 29, 2024

No description provided.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (7fa0c2d) to head (e8d808d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5573   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files         465      465           
  Lines       37772    37772           
  Branches     5580     5580           
=======================================
  Hits        36447    36447           
  Misses       1283     1283           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua changed the title chore(assert): mark the 2nd arg of AssertionError constructor unstable chore(assert): mark options argument of AssertionError constructor unstable Jul 29, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, this PR doesn't achieve anything, given how trivial this addition is and it's unlikeliness to change in the future. Nevertheless, LGTM, if opinions are strong enough.

@kt3k kt3k merged commit b064ee1 into denoland:main Jul 30, 2024
14 checks passed
@kt3k kt3k deleted the chore-assert-assertion-error-constructor-2nd-arg-unstable branch July 30, 2024 02:15
@kt3k kt3k mentioned this pull request Aug 2, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants