Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ini): add type param for value type #5588

Merged
merged 4 commits into from
Aug 2, 2024
Merged

feat(ini): add type param for value type #5588

merged 4 commits into from
Aug 2, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jul 31, 2024

Towards #4807 for parse().

@github-actions github-actions bot added the ini label Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.37%. Comparing base (714fccb) to head (c881593).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5588   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files         465      465           
  Lines       37506    37508    +2     
  Branches     5527     5527           
=======================================
+ Hits        36147    36149    +2     
  Misses       1317     1317           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua requested a review from dsherret August 1, 2024 00:29
@iuioiua iuioiua marked this pull request as ready for review August 1, 2024 00:29
@iuioiua iuioiua requested a review from kt3k as a code owner August 1, 2024 00:29
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit d205617 into main Aug 2, 2024
13 checks passed
@iuioiua iuioiua deleted the ini-parse-type branch August 2, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants