Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ini): correctly handle quoted values in parse() #5592

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jul 31, 2024

Fixes #4808

@iuioiua iuioiua requested a review from kt3k as a code owner July 31, 2024 07:19
@iuioiua iuioiua enabled auto-merge (squash) July 31, 2024 07:19
@github-actions github-actions bot added the ini label Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.37%. Comparing base (ee46c4d) to head (920e6eb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5592   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files         465      465           
  Lines       37494    37500    +6     
  Branches     5525     5527    +2     
=======================================
+ Hits        36135    36141    +6     
  Misses       1317     1317           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua requested a review from dsherret July 31, 2024 23:43
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's keep iterating on other edge cases

@iuioiua iuioiua merged commit 69a579e into main Aug 2, 2024
13 checks passed
@iuioiua iuioiua deleted the ini-parse-quote branch August 2, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ini file value parsed with quotes contains quotes in value
2 participants