test(async): fix abortable.AsyncIterable() calls return before throwing test
#5596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5596 +/- ##
=======================================
Coverage 96.37% 96.37%
=======================================
Files 465 466 +1
Lines 37506 37526 +20
Branches 5527 5528 +1
=======================================
+ Hits 36147 36167 +20
Misses 1317 1317
Partials 42 42 ☔ View full report in Codecov by Sentry. |
kt3k
reviewed
Aug 1, 2024
async/abortable_test.ts
Outdated
Comment on lines
141
to
145
| const timeoutId = setTimeout( | ||
| () => resolve({ value: "Hello", done: false }), | ||
| 1, | ||
| ); | ||
| clearTimeout(timeoutId); |
There was a problem hiding this comment.
These 4 lines look equivalent of nop (timer is created and immediately deleted). I wonder if there's a better fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/denoland/std/actions/runs/10189680039/job/28188160624