Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): simplify parseArgs() logic #5601

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

timreichen
Copy link
Contributor

No description provided.

@timreichen timreichen requested a review from kt3k as a code owner August 1, 2024 10:44
@github-actions github-actions bot added the cli label Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.37%. Comparing base (89770fc) to head (a5afb9a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5601      +/-   ##
==========================================
- Coverage   96.37%   96.37%   -0.01%     
==========================================
  Files         466      466              
  Lines       37576    37574       -2     
  Branches     5540     5538       -2     
==========================================
- Hits        36215    36213       -2     
  Misses       1319     1319              
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua changed the title chore(cli): simplify convoluted code chore(cli): simplify parseArgs() logic Aug 1, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@iuioiua iuioiua enabled auto-merge (squash) August 1, 2024 11:21
auto-merge was automatically disabled August 1, 2024 13:00

Head branch was pushed to by a user without write access

@iuioiua iuioiua merged commit 0d30f02 into denoland:main Aug 2, 2024
13 checks passed
@timreichen timreichen deleted the cli-simplify-1 branch August 17, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants