Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csv): show 1-based line and column numbers in error messages #5604

Conversation

magurotuna
Copy link
Member

No description provided.

@magurotuna magurotuna requested a review from kt3k as a code owner August 1, 2024 12:06
@github-actions github-actions bot added the csv label Aug 1, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.37%. Comparing base (b5181c1) to head (0309a2c).

Files Patch % Lines
csv/_io.ts 87.09% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5604      +/-   ##
==========================================
- Coverage   96.38%   96.37%   -0.01%     
==========================================
  Files         466      466              
  Lines       37554    37576      +22     
  Branches     5538     5540       +2     
==========================================
+ Hits        36196    36215      +19     
- Misses       1316     1319       +3     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@magurotuna magurotuna merged commit 89770fc into denoland:main Aug 1, 2024
13 checks passed
@magurotuna magurotuna deleted the magurotuna/csv-stream-consistent-line-number branch August 1, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants