Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csv): remove undefined from possible value type of parse result #5617

Conversation

magurotuna
Copy link
Member

As we discussed in #5605 (comment), it seems like we never get undefined as a parse result of fields. If there is a mismatch in the number of fields across rows, the parse just throws an error.
To better reflect this in typing, this commit removes undefined from the record value type.

@github-actions github-actions bot added the csv label Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.37%. Comparing base (b0f2088) to head (a2491b1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5617   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files         466      466           
  Lines       37587    37587           
  Branches     5542     5542           
=======================================
  Hits        36226    36226           
  Misses       1319     1319           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@magurotuna magurotuna marked this pull request as ready for review August 2, 2024 05:06
@magurotuna magurotuna requested a review from kt3k as a code owner August 2, 2024 05:06
@magurotuna magurotuna merged commit 8b21698 into denoland:main Aug 2, 2024
13 checks passed
@magurotuna magurotuna deleted the magurotuna/csv-remove-undefined-value-type branch August 2, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants