Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(http): use headers module in file-server module #5642

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Aug 6, 2024

No description provided.

@github-actions github-actions bot added the http label Aug 6, 2024
@iuioiua iuioiua marked this pull request as ready for review August 6, 2024 12:57
@iuioiua iuioiua requested a review from kt3k as a code owner August 6, 2024 12:57
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (889a63d) to head (7d9fb62).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5642   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files         468      468           
  Lines       38219    38220    +1     
  Branches     5542     5542           
=======================================
+ Hits        36862    36863    +1     
  Misses       1315     1315           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit d99e1f8 into main Aug 6, 2024
13 checks passed
@iuioiua iuioiua deleted the http-use-headers branch August 6, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants