Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(datetime): cleanup DateTimeFormatter and parse() function #5649

Merged
merged 6 commits into from
Aug 8, 2024

Conversation

timreichen
Copy link
Contributor

No description provided.

@timreichen timreichen requested a review from kt3k as a code owner August 7, 2024 10:44
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 81.91489% with 17 lines in your changes missing coverage. Please review.

Project coverage is 96.21%. Comparing base (4432ba1) to head (a21c9fe).
Report is 6 commits behind head on main.

Files Patch % Lines
datetime/_date_time_formatter.ts 81.52% 17 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5649   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files         469      470    +1     
  Lines       38181    38201   +20     
  Branches     5539     5549   +10     
=======================================
+ Hits        36735    36756   +21     
+ Misses       1404     1403    -1     
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua changed the title refactor(datetime): cleanup DateTimeFormatter and parse function refactor(datetime): cleanup DateTimeFormatter and parse() function Aug 8, 2024
@iuioiua iuioiua merged commit c7a39f0 into denoland:main Aug 8, 2024
11 checks passed
@timreichen timreichen deleted the datetime-cleanup-parse branch August 17, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants