Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): add stringify() method to DumperState #5707

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

timreichen
Copy link
Contributor

Changes
This PR moves the stringify() logic inside the DumperState.

Reasoning
This allows the reduction of any types. Other methods can be made private in a future PR.

@timreichen timreichen requested a review from kt3k as a code owner August 18, 2024 00:04
@github-actions github-actions bot added the yaml label Aug 18, 2024
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.25%. Comparing base (1bc290b) to head (461efd7).
Report is 2 commits behind head on main.

Files Patch % Lines
yaml/_dumper_state.ts 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5707      +/-   ##
==========================================
- Coverage   96.25%   96.25%   -0.01%     
==========================================
  Files         477      477              
  Lines       38512    38514       +2     
  Branches     5585     5585              
==========================================
+ Hits        37070    37071       +1     
- Misses       1400     1401       +1     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit aa836f2 into denoland:main Aug 19, 2024
13 checks passed
@timreichen timreichen deleted the yaml-stringify-method branch August 19, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants