Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(yaml): add test for deprecated boolean syntax #5713

Merged

Conversation

timreichen
Copy link
Contributor

Changes
This PR adds a test for deprecated boolean syntax with compatMode: true.

@timreichen timreichen requested a review from kt3k as a code owner August 18, 2024 14:34
@github-actions github-actions bot added the yaml label Aug 18, 2024
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.26%. Comparing base (75cb767) to head (a7d709e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5713   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files         477      477           
  Lines       38512    38512           
  Branches     5589     5589           
=======================================
+ Hits        37072    37074    +2     
+ Misses       1398     1396    -2     
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yaml/stringify_test.ts Outdated Show resolved Hide resolved
@timreichen timreichen changed the title feat(yaml): add test for deprecated boolean syntax test(yaml): add test for deprecated boolean syntax Aug 19, 2024
@iuioiua
Copy link
Contributor

iuioiua commented Aug 19, 2024

Nice! These PRs that target test coverage are very welcome.

@iuioiua iuioiua merged commit b929d05 into denoland:main Aug 19, 2024
13 checks passed
@timreichen timreichen deleted the yaml-add-deprecated-boolean-syntax-test branch August 20, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants