Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(log): replace protected properties with Symbols #5724

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

timreichen
Copy link
Contributor

Changes
This PR replaces protected properties with Symbols.

Reasoning
Either the properties should be public and not have an underscore or private and thus not accessible.

@timreichen timreichen requested a review from kt3k as a code owner August 19, 2024 08:13
@github-actions github-actions bot added the log label Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 98.55072% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.26%. Comparing base (75cb767) to head (2cca4b6).
Report is 3 commits behind head on main.

Files Patch % Lines
log/file_handler.ts 97.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5724   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files         477      478    +1     
  Lines       38512    38541   +29     
  Branches     5589     5589           
=======================================
+ Hits        37072    37102   +30     
+ Misses       1398     1397    -1     
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timreichen timreichen changed the title reafctor(log): replace protected properties with Symbols refactor(log): replace protected properties with Symbols Aug 19, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 2d6ae7d into denoland:main Aug 20, 2024
13 checks passed
@timreichen timreichen deleted the log-replace-protected-with-symbols branch August 20, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants