perf(cli,http,ini,internal,media-types): replace trim() comparisons with regexps
#5751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5751 +/- ##
=======================================
Coverage 96.28% 96.28%
=======================================
Files 474 474
Lines 38383 38389 +6
Branches 5578 5579 +1
=======================================
+ Hits 36957 36964 +7
+ Misses 1384 1383 -1
Partials 42 42 ☔ View full report in Codecov by Sentry. |
kt3k
changed the title
trim() comparisons with regexpstrim() comparisons with regexps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This replaces comparisons done with
trim()withRegExp.test()Reasoning
trim()creates a new string which is only used for the comparison and thus not memory efficient.