Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(encoding): align additional error messages #5767

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

irbull
Copy link
Contributor

@irbull irbull commented Aug 22, 2024

Aligns the error messages in the encoding folder to match the style guide.

#5574

Aligns the error messages in the `encoding` folder to match the
style guide.

denoland#5574
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (0332f0a) to head (4f54d42).
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5767      +/-   ##
==========================================
- Coverage   96.26%   96.23%   -0.03%     
==========================================
  Files         475      481       +6     
  Lines       38480    38754     +274     
  Branches     5587     5618      +31     
==========================================
+ Hits        37041    37295     +254     
- Misses       1397     1418      +21     
+ Partials       42       41       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

encoding/_base32_common.ts Outdated Show resolved Hide resolved
encoding/hex.ts Outdated Show resolved Hide resolved
encoding/varint.ts Outdated Show resolved Hide resolved
encoding/varint.ts Outdated Show resolved Hide resolved
encoding/varint.ts Outdated Show resolved Hide resolved
encoding/varint.ts Outdated Show resolved Hide resolved
irbull and others added 2 commits August 22, 2024 16:34
Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 479b258 into denoland:main Aug 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants