Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): remove schema property #5798

Merged
merged 5 commits into from
Aug 24, 2024

Conversation

timreichen
Copy link
Contributor

Changes
This PR removes the schema property in DumperState.

Reasoning
This property is not used anywhere.

@timreichen timreichen requested a review from kt3k as a code owner August 23, 2024 19:45
@github-actions github-actions bot added the yaml label Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (95d7b43) to head (e5793c7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5798      +/-   ##
==========================================
+ Coverage   96.22%   96.23%   +0.01%     
==========================================
  Files         481      481              
  Lines       38766    38764       -2     
  Branches     5616     5616              
==========================================
+ Hits        37303    37306       +3     
+ Misses       1422     1417       -5     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit c8fe634 into denoland:main Aug 24, 2024
16 checks passed
@timreichen timreichen deleted the yaml-remove-schema-property branch August 24, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants