Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): remove Mark class #5805

Merged
merged 3 commits into from
Aug 25, 2024

Conversation

timreichen
Copy link
Contributor

@timreichen timreichen commented Aug 24, 2024

Changes
This PR removes the Mark class and replaces it with functions.

Reasoning
Mark is only used in #createError(). It seems inefficient to instantiate a class instead of creating and returning the string directly in a function.

@timreichen timreichen requested a review from kt3k as a code owner August 24, 2024 06:14
@github-actions github-actions bot added the yaml label Aug 24, 2024
Copy link

codecov bot commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 73.17073% with 11 lines in your changes missing coverage. Please review.

Project coverage is 96.23%. Comparing base (c817a5a) to head (d6af634).
Report is 3 commits behind head on main.

Files Patch % Lines
yaml/_loader_state.ts 73.17% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5805      +/-   ##
==========================================
- Coverage   96.23%   96.23%   -0.01%     
==========================================
  Files         480      479       -1     
  Lines       38748    38727      -21     
  Branches     5616     5615       -1     
==========================================
- Hits        37291    37269      -22     
- Misses       1416     1417       +1     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thank you.

@iuioiua iuioiua merged commit 08f4079 into denoland:main Aug 25, 2024
16 checks passed
@timreichen timreichen deleted the yaml-remove-mark-class branch August 25, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants