Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): move isObject() #5823

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

timreichen
Copy link
Contributor

@timreichen timreichen commented Aug 26, 2024

Changes
This PR moves isObject() check to a separate block to avoid double check.

@timreichen timreichen requested a review from kt3k as a code owner August 26, 2024 07:46
@github-actions github-actions bot added the yaml label Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.28%. Comparing base (7fc1940) to head (074fff7).
Report is 1 commits behind head on main.

Files Patch % Lines
yaml/_dumper_state.ts 89.28% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5823   +/-   ##
=======================================
  Coverage   96.27%   96.28%           
=======================================
  Files         479      479           
  Lines       38744    38746    +2     
  Branches     5621     5623    +2     
=======================================
+ Hits        37302    37307    +5     
+ Misses       1399     1396    -3     
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yaml/_dumper_state.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@iuioiua iuioiua enabled auto-merge (squash) August 26, 2024 23:15
@iuioiua iuioiua merged commit 52c65f9 into denoland:main Aug 26, 2024
16 checks passed
@timreichen timreichen deleted the yaml-move-`isObject()` branch August 27, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants