Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(msgpack): accept readonly input data in encode() #5832

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

lionel-rowe
Copy link
Contributor

Towards #5831

@lionel-rowe lionel-rowe requested a review from kt3k as a code owner August 26, 2024 12:24
@lionel-rowe lionel-rowe force-pushed the msgpack-readonly-input branch from 2bf4b52 to 5508c9d Compare August 26, 2024 12:32
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (7fc1940) to head (e92fa5e).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5832   +/-   ##
=======================================
  Coverage   96.27%   96.27%           
=======================================
  Files         479      479           
  Lines       38744    38744           
  Branches     5621     5621           
=======================================
  Hits        37302    37302           
  Misses       1399     1399           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k changed the title feat(msgpack): accept readonly input data (#5831) fix(msgpack): accept readonly input data (#5831) Aug 27, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua changed the title fix(msgpack): accept readonly input data (#5831) fix(msgpack): accept readonly input data Aug 27, 2024
@iuioiua iuioiua changed the title fix(msgpack): accept readonly input data fix(msgpack): accept readonly input data in encode() Aug 27, 2024
@iuioiua iuioiua merged commit 15fc72c into denoland:main Aug 27, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants