refactor(yaml): move duplicate and duplicateIndex
#5836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5836 +/- ##
==========================================
- Coverage 96.26% 96.25% -0.01%
==========================================
Files 479 479
Lines 38705 38698 -7
Branches 5617 5617
==========================================
- Hits 37258 37250 -8
Misses 1404 1404
- Partials 43 44 +1 ☔ View full report in Codecov by Sentry. |
iuioiua
reviewed
Aug 29, 2024
| } | ||
| if (duplicate) { | ||
| if (this.usedDuplicates.has(value)) return `*ref_${duplicateIndex}`; | ||
| this.usedDuplicates.add(value); |
There was a problem hiding this comment.
This doesn't seem to pertain to the main objective of this PR.
There was a problem hiding this comment.
if (duplicate) {...} would be checked twice otherwise, no?
Comment on lines
+792
to
+798
| if ( | ||
| (tag !== null && tag !== "?") || | ||
| duplicate || | ||
| (this.indent !== 2 && level > 0) | ||
| ) { | ||
| compact = false; | ||
| } |
There was a problem hiding this comment.
Because compact only needs to be evaluated after if (this.usedDuplicates.has(value)) return ``*ref_${duplicateIndex}``; doesn't return early.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR moves
duplicateandduplicateIndexcode insideisObject()block, to avoid double check.Note One line
(tag !== null && tag !== "?")is not covered. Seems like tag is always null if the value is an object.