Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): switch array test #5898

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

timreichen
Copy link
Contributor

Changes
This PR switches the blocks so Array.isArray() test is positive not negative.

@timreichen timreichen requested a review from kt3k as a code owner September 3, 2024 11:48
@github-actions github-actions bot added the yaml label Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (2d6c45e) to head (a90fdb0).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5898      +/-   ##
==========================================
- Coverage   96.33%   96.32%   -0.02%     
==========================================
  Files         483      483              
  Lines       39042    39063      +21     
  Branches     5712     5730      +18     
==========================================
+ Hits        37613    37626      +13     
- Misses       1385     1393       +8     
  Partials       44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua merged commit df562b1 into denoland:main Sep 3, 2024
16 checks passed
@timreichen timreichen deleted the yaml-switch-array-test branch September 3, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants