Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(path/unstable): support string | URL in the 2nd overload of basename, dirname, and extname #5904

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Sep 4, 2024

This PR changes the (unstable) 2nd overloads of basename, dirname, and extname to accept string | URL type. Now the 2nd overloads show how the APIs look like when they are stabilized . This also reduces the internal use of any types.

related: #5537

@github-actions github-actions bot added the path label Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.32%. Comparing base (6aaf191) to head (f8b259b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
path/basename.ts 0.00% 2 Missing ⚠️
path/dirname.ts 0.00% 1 Missing ⚠️
path/extname.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5904      +/-   ##
==========================================
- Coverage   96.32%   96.32%   -0.01%     
==========================================
  Files         484      484              
  Lines       39112    39110       -2     
  Branches     5739     5739              
==========================================
- Hits        37675    37673       -2     
  Misses       1393     1393              
  Partials       44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k merged commit 1432018 into denoland:main Sep 4, 2024
17 checks passed
@kt3k kt3k deleted the path-support-string-url-in-2nd-overload branch September 4, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants