Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(encoding/unstable): move hex-stream module to unstable-hex-stream #5960

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Sep 12, 2024

Towards #5920

@iuioiua iuioiua requested a review from kt3k as a code owner September 12, 2024 05:55
@iuioiua iuioiua enabled auto-merge (squash) September 12, 2024 05:55
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (0ff29d1) to head (a88dd1d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5960      +/-   ##
==========================================
- Coverage   96.32%   96.32%   -0.01%     
==========================================
  Files         484      486       +2     
  Lines       39403    39425      +22     
  Branches     5837     5836       -1     
==========================================
+ Hits        37956    37976      +20     
- Misses       1405     1407       +2     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 93ccb64 into main Sep 12, 2024
16 checks passed
@iuioiua iuioiua deleted the move-unstable-hex-stream branch September 12, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants