Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(path/unstable): move unstable overload of extname to unstable-extname #5962

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Sep 12, 2024

part of #5920

This PR moves the unstable overload of extname function to ./unstable-extname

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (ecd8a2e) to head (edbb0eb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5962   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files         486      488    +2     
  Lines       39425    39447   +22     
  Branches     5837     5834    -3     
=======================================
+ Hits        37976    37998   +22     
  Misses       1407     1407           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@kt3k kt3k merged commit 99aaaf8 into denoland:main Sep 12, 2024
16 checks passed
@kt3k kt3k deleted the breaking-path-move-unstable-extname branch September 12, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants