From bdf4c10819cf884bc7eebba5321109c4665c515f Mon Sep 17 00:00:00 2001 From: noahhansen-gov <166541737+noahhansen-gov@users.noreply.github.com> Date: Thu, 8 Aug 2024 07:57:23 -0600 Subject: [PATCH] APPEALS-53603: Modify logic to always show recipient information if present (#22414) * initial commit * making rspec tests happy * linting * adding tests back and refactoring * small char error --------- Co-authored-by: nhansen3 --- client/app/queue/components/NotificationTableColumns.jsx | 2 +- client/test/data/notifications.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/client/app/queue/components/NotificationTableColumns.jsx b/client/app/queue/components/NotificationTableColumns.jsx index 592e8c775af..e23aa966832 100644 --- a/client/app/queue/components/NotificationTableColumns.jsx +++ b/client/app/queue/components/NotificationTableColumns.jsx @@ -81,7 +81,7 @@ export const recipientInformationColumn = (notifications) => { tableData: notifications, valueName: 'Recipient Information', // eslint-disable-next-line no-negated-condition - valueFunction: (notification) => notification.status !== 'delivered' ? '—' : notification.recipient_information + valueFunction: (notification) => notification.recipient_information ?? '—' }; }; diff --git a/client/test/data/notifications.js b/client/test/data/notifications.js index b31dd46ccf6..af53219e4c0 100644 --- a/client/test/data/notifications.js +++ b/client/test/data/notifications.js @@ -118,9 +118,9 @@ export const notifications = [ notification_type: 'Email and SMS', event_date: '2022-10-27', event_type: 'Appeal decision mailed (Non-contested claims)', - recipient_email: 'test@caseflow.com', + recipient_email: null, recipient_phone_number: '2468012345', - email_notification_status: 'sent', + email_notification_status: 'temporary-failure', sms_notification_status: 'delivered', notification_content: 'string' }