From 4387c757f66af3117416e03fd97e2a8f13982b4b Mon Sep 17 00:00:00 2001 From: Ariana Konhilas Date: Tue, 21 Nov 2023 15:01:31 -0500 Subject: [PATCH 1/3] APPEALS-35195: update sub to use unique hearing day id --- app/models/hearing_day.rb | 2 +- spec/models/hearing_day_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/models/hearing_day.rb b/app/models/hearing_day.rb index 862eded87dd..c4dddfb905e 100644 --- a/app/models/hearing_day.rb +++ b/app/models/hearing_day.rb @@ -227,7 +227,7 @@ def conference_links end def subject_for_conference - "Guest Link for #{scheduled_for.strftime('%b %e, %Y')}" + "#{id}_#{scheduled_for.strftime('%b %e, %Y')}" end def nbf diff --git a/spec/models/hearing_day_spec.rb b/spec/models/hearing_day_spec.rb index 2b849b8ed58..8278e936fc4 100644 --- a/spec/models/hearing_day_spec.rb +++ b/spec/models/hearing_day_spec.rb @@ -607,7 +607,7 @@ def format_begins_at_from_db(time_string, scheduled_for) subject { hearing_day.subject_for_conference } it "returns the expected meeting conference details" do - is_expected.to eq("Guest Link for #{expected_date}") + is_expected.to eq("#{hearing_day.id}_#{expected_date}") end context "nbf and exp" do From ca377b1bb21cce7b4aa772f778f7214203e9e158 Mon Sep 17 00:00:00 2001 From: Ariana Konhilas Date: Tue, 21 Nov 2023 15:49:32 -0500 Subject: [PATCH 2/3] APPEALS-35195: update hearing day spec to have specific id for hearing day --- spec/models/hearing_day_spec.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/spec/models/hearing_day_spec.rb b/spec/models/hearing_day_spec.rb index 8278e936fc4..a417f0c78f6 100644 --- a/spec/models/hearing_day_spec.rb +++ b/spec/models/hearing_day_spec.rb @@ -596,11 +596,13 @@ def format_begins_at_from_db(time_string, scheduled_for) include_context "Enable both conference services" let(:expected_date) { "Sep 21, 2023" } + let(:id) { 2_000_006_656 } let(:expected_date_parsed) { Date.parse(expected_date) } let(:hearing_day) do build( :hearing_day, - scheduled_for: expected_date_parsed + scheduled_for: expected_date_parsed, + id: id ) end From 7311a8e0e4fd1af54144b02fca8f3f3e5398aec9 Mon Sep 17 00:00:00 2001 From: Ariana Konhilas Date: Wed, 22 Nov 2023 12:48:51 -0500 Subject: [PATCH 3/3] APPEALS-35195: change date format --- app/models/hearing_day.rb | 2 +- spec/models/hearing_day_spec.rb | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/app/models/hearing_day.rb b/app/models/hearing_day.rb index c4dddfb905e..0e9faea081f 100644 --- a/app/models/hearing_day.rb +++ b/app/models/hearing_day.rb @@ -227,7 +227,7 @@ def conference_links end def subject_for_conference - "#{id}_#{scheduled_for.strftime('%b %e, %Y')}" + "#{id}_#{scheduled_for.strftime('%m %e, %Y')}" end def nbf diff --git a/spec/models/hearing_day_spec.rb b/spec/models/hearing_day_spec.rb index a417f0c78f6..635ed237cba 100644 --- a/spec/models/hearing_day_spec.rb +++ b/spec/models/hearing_day_spec.rb @@ -595,9 +595,9 @@ def format_begins_at_from_db(time_string, scheduled_for) context "#subject_for_conference" do include_context "Enable both conference services" - let(:expected_date) { "Sep 21, 2023" } + let(:assigned_date) { "Sep 21, 2023" } let(:id) { 2_000_006_656 } - let(:expected_date_parsed) { Date.parse(expected_date) } + let(:expected_date_parsed) { Date.parse(assigned_date) } let(:hearing_day) do build( :hearing_day, @@ -609,6 +609,7 @@ def format_begins_at_from_db(time_string, scheduled_for) subject { hearing_day.subject_for_conference } it "returns the expected meeting conference details" do + expected_date = "09 21, 2023" is_expected.to eq("#{hearing_day.id}_#{expected_date}") end