From 771e2f29230313f4540197f2b107770a793d4963 Mon Sep 17 00:00:00 2001 From: Craig Reese Date: Fri, 17 May 2024 16:17:25 -0500 Subject: [PATCH 01/12] add test to validate cavc+aod on hearing docket appeals --- .../dockets/hearing_request_docket_spec.rb | 49 +++++++++++++++---- 1 file changed, 39 insertions(+), 10 deletions(-) diff --git a/spec/models/dockets/hearing_request_docket_spec.rb b/spec/models/dockets/hearing_request_docket_spec.rb index cc42870ae21..17705b554a3 100644 --- a/spec/models/dockets/hearing_request_docket_spec.rb +++ b/spec/models/dockets/hearing_request_docket_spec.rb @@ -589,16 +589,30 @@ context "with multiple levers enabled and appeals meeting each criteria" do # ready non-aod appeals let!(:ready_cavc_appeal_tied_to_requesting_judge_in_window) do - create_ready_cavc_appeal(tied_judge: requesting_judge_no_attorneys, created_date: 7.days.ago) + create_ready_cavc_appeal(tied_judge: requesting_judge_no_attorneys, created_date: 15.days.ago) end - let!(:ready_cavc_appeal_tied_to_requesting_judge_out_of_window_21_days) do - create_ready_cavc_appeal(tied_judge: requesting_judge_no_attorneys, created_date: 21.days.ago) + let!(:ready_cavc_appeal_tied_to_requesting_judge_out_of_window_22_days) do + create_ready_cavc_appeal(tied_judge: requesting_judge_no_attorneys, created_date: 22.days.ago) end let!(:ready_cavc_appeal_tied_to_other_judge_in_window) do - create_ready_cavc_appeal(tied_judge: other_judge, created_date: 7.days.ago) + create_ready_cavc_appeal(tied_judge: other_judge, created_date: 15.days.ago) end - let!(:ready_cavc_appeal_tied_to_other_judge_out_of_window_21_days) do - create_ready_cavc_appeal(tied_judge: other_judge, created_date: 21.days.ago) + let!(:ready_cavc_appeal_tied_to_other_judge_out_of_window_22_days) do + create_ready_cavc_appeal(tied_judge: other_judge, created_date: 22.days.ago) + end + + # ready aod + cavc appeals to verify that distribution uses the lowest lever value to distribute + let!(:ready_cavc_aod_appeal_tied_to_requesting_judge_in_window) do + create_ready_cavc_appeal(tied_judge: requesting_judge_no_attorneys, created_date: 5.days.ago, aod: true) + end + let!(:ready_cavc_aod_appeal_tied_to_requesting_judge_out_of_window_10_days) do + create_ready_cavc_appeal(tied_judge: requesting_judge_no_attorneys, created_date: 10.days.ago, aod: true) + end + let!(:ready_cavc_aod_appeal_tied_to_other_judge_in_window) do + create_ready_cavc_appeal(tied_judge: other_judge, created_date: 5.days.ago, aod: true) + end + let!(:ready_cavc_aod_appeal_tied_to_other_judge_out_of_window_10_days) do + create_ready_cavc_appeal(tied_judge: other_judge, created_date: 10.days.ago, aod: true) end # ready aod appeals @@ -627,7 +641,8 @@ before do FeatureToggle.enable!(:specialty_case_team_distribution) CaseDistributionLever.find_by_item(Constants.DISTRIBUTION.ama_hearing_case_affinity_days).update!(value: "30") - CaseDistributionLever.find_by_item(Constants.DISTRIBUTION.cavc_affinity_days).update!(value: "14") + CaseDistributionLever.find_by_item(Constants.DISTRIBUTION.cavc_affinity_days).update!(value: "21") + CaseDistributionLever.find_by_item(Constants.DISTRIBUTION.cavc_aod_affinity_days).update!(value: "7") CaseDistributionLever .find_by_item(Constants.DISTRIBUTION.ama_hearing_case_aod_affinity_days) .update!(value: "15") @@ -639,8 +654,11 @@ it "distributes appeals as expected" do expect(subject.map(&:case_id)).to match_array( [ready_cavc_appeal_tied_to_requesting_judge_in_window.uuid, - ready_cavc_appeal_tied_to_requesting_judge_out_of_window_21_days.uuid, - ready_cavc_appeal_tied_to_other_judge_out_of_window_21_days.uuid, + ready_cavc_appeal_tied_to_requesting_judge_out_of_window_22_days.uuid, + ready_cavc_appeal_tied_to_other_judge_out_of_window_22_days.uuid, + ready_cavc_aod_appeal_tied_to_requesting_judge_in_window.uuid, + ready_cavc_aod_appeal_tied_to_requesting_judge_out_of_window_10_days.uuid, + ready_cavc_aod_appeal_tied_to_other_judge_out_of_window_10_days.uuid, ready_aod_tied_to_requesting_judge_in_window.uuid, ready_aod_tied_to_requesting_judge_out_of_window_20_days.uuid, ready_aod_tied_to_other_judge_out_of_window_20_days.uuid, @@ -667,7 +685,7 @@ def create_ready_aod_appeal(tied_judge: nil, created_date: 1.year.ago) appeal end - def create_ready_cavc_appeal(tied_judge: nil, created_date: 1.year.ago) + def create_ready_cavc_appeal(tied_judge: nil, created_date: 1.year.ago, aod: false) Timecop.travel(created_date - 6.months) if tied_judge judge = tied_judge @@ -699,6 +717,17 @@ def create_ready_cavc_appeal(tied_judge: nil, created_date: 1.year.ago) (distribution_tasks.flat_map(&:descendants) - distribution_tasks).each(&:completed!) Timecop.return + if aod + create( + :advance_on_docket_motion, + appeal: remand_appeal, + granted: true, + person: source_appeal.claimant.person, + reason: Constants.AOD_REASONS.financial_distress, + user_id: User.system_user.id + ) + end + remand_appeal end From 11a6e9a4e66633a178f2626c2841eb2e8e11ba26 Mon Sep 17 00:00:00 2001 From: Craig Reese Date: Mon, 20 May 2024 08:06:13 -0500 Subject: [PATCH 02/12] lint, test case_docket_spec fix --- .../dockets/hearing_request_docket_spec.rb | 22 ++++++++++--------- spec/models/vacols/case_docket_spec.rb | 2 +- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/spec/models/dockets/hearing_request_docket_spec.rb b/spec/models/dockets/hearing_request_docket_spec.rb index 17705b554a3..33feb362d7e 100644 --- a/spec/models/dockets/hearing_request_docket_spec.rb +++ b/spec/models/dockets/hearing_request_docket_spec.rb @@ -717,20 +717,22 @@ def create_ready_cavc_appeal(tied_judge: nil, created_date: 1.year.ago, aod: fal (distribution_tasks.flat_map(&:descendants) - distribution_tasks).each(&:completed!) Timecop.return - if aod - create( - :advance_on_docket_motion, - appeal: remand_appeal, - granted: true, - person: source_appeal.claimant.person, - reason: Constants.AOD_REASONS.financial_distress, - user_id: User.system_user.id - ) - end + create_aod_motion(remand_appeal, remand_appeal.claimant.person) if aod remand_appeal end + def create_aod_motion(appeal, person) + create( + :advance_on_docket_motion, + appeal: appeal, + granted: true, + person: person, + reason: Constants.AOD_REASONS.financial_distress, + user_id: User.system_user.id + ) + end + def create_ready_nonpriority_appeal(tied_judge: nil, created_date: 1.year.ago) Timecop.travel(created_date) appeal = create( diff --git a/spec/models/vacols/case_docket_spec.rb b/spec/models/vacols/case_docket_spec.rb index 5b6929e9a6e..9a627fbd6fd 100644 --- a/spec/models/vacols/case_docket_spec.rb +++ b/spec/models/vacols/case_docket_spec.rb @@ -63,7 +63,7 @@ let(:third_nonpriority_ready_case_docket_number) { "1801005" } let(:third_nonpriority_ready_case) do create(:case, - bfd19: 1.year.ago, + bfd19: 10.months.ago, bfac: "3", bfmpro: "ACT", bfcurloc: "83", From ec5de40ce95a369514eb42489b8e2829cdf46b62 Mon Sep 17 00:00:00 2001 From: Craig Reese Date: Mon, 20 May 2024 08:58:59 -0500 Subject: [PATCH 03/12] modify case_docket_spec again --- spec/models/vacols/case_docket_spec.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/models/vacols/case_docket_spec.rb b/spec/models/vacols/case_docket_spec.rb index 9a627fbd6fd..a8414f0f37d 100644 --- a/spec/models/vacols/case_docket_spec.rb +++ b/spec/models/vacols/case_docket_spec.rb @@ -29,7 +29,7 @@ bfac: "3", bfmpro: "ACT", bfcurloc: "81", - bfdloout: 1.day.ago, + bfdloout: 3.days.ago, bfbox: nonpriority_ready_case_bfbox, folder: build(:folder, tinum: nonpriority_ready_case_docket_number, titrnum: "123456789S")) end @@ -55,7 +55,7 @@ bfac: "1", bfmpro: "ACT", bfcurloc: "83", - bfdloout: 1.day.ago, + bfdloout: 2.days.ago, folder: build(:folder, tinum: another_nonpriority_ready_case_docket_number, titrnum: "123456789S") ).tap { |vacols_case| create(:mail, :blocking, :completed, mlfolder: vacols_case.bfkey) } end From da40c181fa7c1ef09fa24c63966bd090ce44809a Mon Sep 17 00:00:00 2001 From: Craig Reese Date: Mon, 20 May 2024 09:46:09 -0500 Subject: [PATCH 04/12] more test fix testing --- spec/models/vacols/case_docket_spec.rb | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/spec/models/vacols/case_docket_spec.rb b/spec/models/vacols/case_docket_spec.rb index a8414f0f37d..4915a1bfe53 100644 --- a/spec/models/vacols/case_docket_spec.rb +++ b/spec/models/vacols/case_docket_spec.rb @@ -4,6 +4,7 @@ before do FeatureToggle.enable!(:test_facols) FeatureToggle.enable!(:acd_disable_legacy_lock_ready_appeals) + FeatureToggle.enable!(:acd_distribute_by_docket_date) end after do @@ -445,6 +446,9 @@ let(:bust_backlog) { true } let(:another_hearing_judge) { judge.vacols_attorney_id } + # We don't use bust backlog if this feature toggle is enabled + before { FeatureToggle.disable!(:acd_distribute_by_docket_date) } + context "when the judge does not have 30 cases in their backlog" do it "does not distribute any appeals" do expect(subject.count).to eq(0) From 44bccdd8202948e90ebdbb97163d40a2bdb030f3 Mon Sep 17 00:00:00 2001 From: Craig Reese Date: Mon, 20 May 2024 11:38:12 -0500 Subject: [PATCH 05/12] attempt to fix test again --- spec/models/vacols/case_docket_spec.rb | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/spec/models/vacols/case_docket_spec.rb b/spec/models/vacols/case_docket_spec.rb index 4915a1bfe53..088c1b9633f 100644 --- a/spec/models/vacols/case_docket_spec.rb +++ b/spec/models/vacols/case_docket_spec.rb @@ -328,8 +328,10 @@ let(:bust_backlog) { false } before do - FeatureToggle.enabled?(:acd_cases_tied_to_judges_no_longer_with_board) - third_nonpriority_ready_case + # FeatureToggle.enable!(:acd_cases_tied_to_judges_no_longer_with_board) + nonpriority_ready_case.reload + another_nonpriority_ready_case.reload + third_nonpriority_ready_case.reload end subject { VACOLS::CaseDocket.distribute_nonpriority_appeals(judge, genpop, range, limit, bust_backlog) } From 2ea3c17d8501ecd4105f6bfafc4a3230df096f52 Mon Sep 17 00:00:00 2001 From: Craig Reese Date: Mon, 20 May 2024 12:59:38 -0500 Subject: [PATCH 06/12] test removing prev appeals from nonpriority queries --- app/models/vacols/case_docket.rb | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/app/models/vacols/case_docket.rb b/app/models/vacols/case_docket.rb index 5120733a0ed..7c1e476cf39 100644 --- a/app/models/vacols/case_docket.rb +++ b/app/models/vacols/case_docket.rb @@ -155,35 +155,30 @@ class DocketNumberCentennialLoop < StandardError; end " SELECT_NONPRIORITY_APPEALS = " - select BFKEY, BFDLOOUT, VLJ, DOCKET_INDEX, PREV_TYPE_ACTION, PREV_DECIDING_JUDGE + select BFKEY, BFDLOOUT, VLJ, DOCKET_INDEX from ( select BFKEY, BFDLOOUT, rownum DOCKET_INDEX, - case when BFHINES is null or BFHINES <> 'GP' then VLJ_HEARINGS.VLJ end VLJ, - PREV_APPEAL.PREV_TYPE_ACTION PREV_TYPE_ACTION, PREV_APPEAL.PREV_DECIDING_JUDGE PREV_DECIDING_JUDGE + case when BFHINES is null or BFHINES <> 'GP' then VLJ_HEARINGS.VLJ end VLJ from ( #{SELECT_READY_APPEALS} and BFAC <> '7' and AOD = '0' order by case when substr(TINUM, 1, 2) between '00' and '29' then 1 else 0 end, TINUM ) BRIEFF #{JOIN_ASSOCIATED_VLJS_BY_HEARINGS} - #{JOIN_PREVIOUS_APPEALS} ) " SELECT_NONPRIORITY_APPEALS_ORDER_BY_BFD19 = " - select BFKEY, BFD19, BFDLOOUT, VLJ, DOCKET_INDEX, PREV_TYPE_ACTION, PREV_DECIDING_JUDGE + select BFKEY, BFD19, BFDLOOUT, VLJ, DOCKET_INDEX from ( select BFKEY, BFD19, BFDLOOUT, rownum DOCKET_INDEX, - case when BFHINES is null or BFHINES <> 'GP' then VLJ_HEARINGS.VLJ end VLJ, - PREV_APPEAL.PREV_TYPE_ACTION PREV_TYPE_ACTION, - PREV_APPEAL.PREV_DECIDING_JUDGE PREV_DECIDING_JUDGE + case when BFHINES is null or BFHINES <> 'GP' then VLJ_HEARINGS.VLJ end VLJ from ( #{SELECT_READY_APPEALS} and BFAC <> '7' and AOD = '0' order by case when substr(TINUM, 1, 2) between '00' and '29' then 1 else 0 end, TINUM ) BRIEFF #{JOIN_ASSOCIATED_VLJS_BY_HEARINGS} - #{JOIN_PREVIOUS_APPEALS} order by BFD19 ) " From 3599b81b3c9c7826bb523ef70f90c8d63eb87a91 Mon Sep 17 00:00:00 2001 From: Craig Reese Date: Mon, 20 May 2024 14:06:35 -0500 Subject: [PATCH 07/12] more test tests --- app/models/vacols/case_docket.rb | 13 +++++++++---- spec/models/vacols/case_docket_spec.rb | 6 ++++++ 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/app/models/vacols/case_docket.rb b/app/models/vacols/case_docket.rb index 7c1e476cf39..5120733a0ed 100644 --- a/app/models/vacols/case_docket.rb +++ b/app/models/vacols/case_docket.rb @@ -155,30 +155,35 @@ class DocketNumberCentennialLoop < StandardError; end " SELECT_NONPRIORITY_APPEALS = " - select BFKEY, BFDLOOUT, VLJ, DOCKET_INDEX + select BFKEY, BFDLOOUT, VLJ, DOCKET_INDEX, PREV_TYPE_ACTION, PREV_DECIDING_JUDGE from ( select BFKEY, BFDLOOUT, rownum DOCKET_INDEX, - case when BFHINES is null or BFHINES <> 'GP' then VLJ_HEARINGS.VLJ end VLJ + case when BFHINES is null or BFHINES <> 'GP' then VLJ_HEARINGS.VLJ end VLJ, + PREV_APPEAL.PREV_TYPE_ACTION PREV_TYPE_ACTION, PREV_APPEAL.PREV_DECIDING_JUDGE PREV_DECIDING_JUDGE from ( #{SELECT_READY_APPEALS} and BFAC <> '7' and AOD = '0' order by case when substr(TINUM, 1, 2) between '00' and '29' then 1 else 0 end, TINUM ) BRIEFF #{JOIN_ASSOCIATED_VLJS_BY_HEARINGS} + #{JOIN_PREVIOUS_APPEALS} ) " SELECT_NONPRIORITY_APPEALS_ORDER_BY_BFD19 = " - select BFKEY, BFD19, BFDLOOUT, VLJ, DOCKET_INDEX + select BFKEY, BFD19, BFDLOOUT, VLJ, DOCKET_INDEX, PREV_TYPE_ACTION, PREV_DECIDING_JUDGE from ( select BFKEY, BFD19, BFDLOOUT, rownum DOCKET_INDEX, - case when BFHINES is null or BFHINES <> 'GP' then VLJ_HEARINGS.VLJ end VLJ + case when BFHINES is null or BFHINES <> 'GP' then VLJ_HEARINGS.VLJ end VLJ, + PREV_APPEAL.PREV_TYPE_ACTION PREV_TYPE_ACTION, + PREV_APPEAL.PREV_DECIDING_JUDGE PREV_DECIDING_JUDGE from ( #{SELECT_READY_APPEALS} and BFAC <> '7' and AOD = '0' order by case when substr(TINUM, 1, 2) between '00' and '29' then 1 else 0 end, TINUM ) BRIEFF #{JOIN_ASSOCIATED_VLJS_BY_HEARINGS} + #{JOIN_PREVIOUS_APPEALS} order by BFD19 ) " diff --git a/spec/models/vacols/case_docket_spec.rb b/spec/models/vacols/case_docket_spec.rb index 088c1b9633f..dbe05fcaf4e 100644 --- a/spec/models/vacols/case_docket_spec.rb +++ b/spec/models/vacols/case_docket_spec.rb @@ -353,6 +353,7 @@ let(:limit) { 1 } it "only distributes cases to the limit" do expect(subject.count).to eq(1) + expect(subject.first["bfkey"]).to eq nonpriority_ready_case.bfkey expect(nonpriority_ready_case.reload.bfcurloc).to eq(judge.vacols_uniq_id) expect(another_nonpriority_ready_case.reload.bfcurloc).to eq("83") expect(third_nonpriority_ready_case.reload.bfcurloc).to eq("83") @@ -363,6 +364,7 @@ let(:range) { 1 } it "only distributes cases within the range" do expect(subject.count).to eq(1) + expect(subject.first["bfkey"]).to eq nonpriority_ready_case.bfkey expect(nonpriority_ready_case.reload.bfcurloc).to eq(judge.vacols_uniq_id) expect(another_nonpriority_ready_case.reload.bfcurloc).to eq("83") expect(third_nonpriority_ready_case.reload.bfcurloc).to eq("83") @@ -372,6 +374,7 @@ let(:another_nonpriority_ready_case_docket_number) { "9901002" } it "correctly orders the docket" do expect(subject.count).to eq(1) + expect(subject.first["bfkey"]).to eq another_nonpriority_ready_case.bfkey expect(nonpriority_ready_case.reload.bfcurloc).to eq("81") expect(another_nonpriority_ready_case.reload.bfcurloc).to eq(judge.vacols_uniq_id) expect(third_nonpriority_ready_case.reload.bfcurloc).to eq("83") @@ -402,6 +405,7 @@ let(:genpop) { "not_genpop" } it "distributes the case" do expect(subject.count).to eq(1) + expect(subject.first["bfkey"]).to eq nonpriority_ready_case.bfkey expect(nonpriority_ready_case.reload.bfcurloc).to eq(judge.vacols_uniq_id) expect(another_nonpriority_ready_case.reload.bfcurloc).to eq("83") expect(third_nonpriority_ready_case.reload.bfcurloc).to eq("83") @@ -421,6 +425,7 @@ let(:genpop) { "only_genpop" } it "does distribute the case only tied to inactive judge" do expect(subject.count).to eq(1) + expect(subject.first["bfkey"]).to eq third_nonpriority_ready_case.bfkey expect(third_nonpriority_ready_case.reload.bfcurloc).to eq(judge.vacols_uniq_id) expect(nonpriority_ready_case.reload.bfcurloc).to eq("81") expect(another_nonpriority_ready_case.reload.bfcurloc).to eq("83") @@ -469,6 +474,7 @@ it "only distributes the one case to get back down to 30" do expect(subject.count).to eq(number_of_cases_over_backlog) + expect(subject.first["bfkey"]).to eq nonpriority_ready_case.bfkey expect(nonpriority_ready_case.reload.bfcurloc).to eq(judge.vacols_uniq_id) expect(another_nonpriority_ready_case.reload.bfcurloc).to eq("83") end From 89c86f8e67edda11bf70b188ef9ab6cff4355fa5 Mon Sep 17 00:00:00 2001 From: Craig Reese Date: Mon, 20 May 2024 15:26:41 -0500 Subject: [PATCH 08/12] feature toggle change in test --- spec/models/vacols/case_docket_spec.rb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/spec/models/vacols/case_docket_spec.rb b/spec/models/vacols/case_docket_spec.rb index dbe05fcaf4e..7ec250ed32e 100644 --- a/spec/models/vacols/case_docket_spec.rb +++ b/spec/models/vacols/case_docket_spec.rb @@ -328,7 +328,7 @@ let(:bust_backlog) { false } before do - # FeatureToggle.enable!(:acd_cases_tied_to_judges_no_longer_with_board) + FeatureToggle.enable!(:acd_cases_tied_to_judges_no_longer_with_board) nonpriority_ready_case.reload another_nonpriority_ready_case.reload third_nonpriority_ready_case.reload @@ -362,6 +362,10 @@ context "when range is specified" do let(:range) { 1 } + + # We do not provide a range if this feature toggle is enabled + before { FeatureToggle.disable!(:acd_distribute_by_docket_date) } + it "only distributes cases within the range" do expect(subject.count).to eq(1) expect(subject.first["bfkey"]).to eq nonpriority_ready_case.bfkey From 4c24647a3d204a45fdc2cf5eb3b8f6dbf814cd45 Mon Sep 17 00:00:00 2001 From: Craig Reese Date: Tue, 21 May 2024 07:20:51 -0500 Subject: [PATCH 09/12] reorder new portions of query --- app/models/vacols/case_docket.rb | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/models/vacols/case_docket.rb b/app/models/vacols/case_docket.rb index 5120733a0ed..56b4f4c5565 100644 --- a/app/models/vacols/case_docket.rb +++ b/app/models/vacols/case_docket.rb @@ -117,7 +117,8 @@ class DocketNumberCentennialLoop < StandardError; end ) PREV_APPEAL on PREV_APPEAL.PREV_BFKEY != BRIEFF.BFKEY and PREV_APPEAL.PREV_BFCORLID = BRIEFF.BFCORLID and PREV_APPEAL.PREV_TINUM = BRIEFF.TINUM and PREV_APPEAL.PREV_TITRNUM = BRIEFF.TITRNUM - and PREV_APPEAL.PREV_BFDDEC = BRIEFF.BFDPDCN" + and PREV_APPEAL.PREV_BFDDEC = BRIEFF.BFDPDCN + " SELECT_PRIORITY_APPEALS = " select BFKEY, BFDLOOUT, VLJ, PREV_TYPE_ACTION, PREV_DECIDING_JUDGE @@ -158,8 +159,8 @@ class DocketNumberCentennialLoop < StandardError; end select BFKEY, BFDLOOUT, VLJ, DOCKET_INDEX, PREV_TYPE_ACTION, PREV_DECIDING_JUDGE from ( select BFKEY, BFDLOOUT, rownum DOCKET_INDEX, - case when BFHINES is null or BFHINES <> 'GP' then VLJ_HEARINGS.VLJ end VLJ, - PREV_APPEAL.PREV_TYPE_ACTION PREV_TYPE_ACTION, PREV_APPEAL.PREV_DECIDING_JUDGE PREV_DECIDING_JUDGE + PREV_APPEAL.PREV_TYPE_ACTION PREV_TYPE_ACTION, PREV_APPEAL.PREV_DECIDING_JUDGE PREV_DECIDING_JUDGE, + case when BFHINES is null or BFHINES <> 'GP' then VLJ_HEARINGS.VLJ end VLJ from ( #{SELECT_READY_APPEALS} and BFAC <> '7' and AOD = '0' @@ -174,9 +175,8 @@ class DocketNumberCentennialLoop < StandardError; end select BFKEY, BFD19, BFDLOOUT, VLJ, DOCKET_INDEX, PREV_TYPE_ACTION, PREV_DECIDING_JUDGE from ( select BFKEY, BFD19, BFDLOOUT, rownum DOCKET_INDEX, - case when BFHINES is null or BFHINES <> 'GP' then VLJ_HEARINGS.VLJ end VLJ, - PREV_APPEAL.PREV_TYPE_ACTION PREV_TYPE_ACTION, - PREV_APPEAL.PREV_DECIDING_JUDGE PREV_DECIDING_JUDGE + PREV_APPEAL.PREV_TYPE_ACTION PREV_TYPE_ACTION, PREV_APPEAL.PREV_DECIDING_JUDGE PREV_DECIDING_JUDGE, + case when BFHINES is null or BFHINES <> 'GP' then VLJ_HEARINGS.VLJ end VLJ from ( #{SELECT_READY_APPEALS} and BFAC <> '7' and AOD = '0' From e8540b40ed2814ce96fe5798f492a97054e05ff7 Mon Sep 17 00:00:00 2001 From: Craig Reese Date: Tue, 21 May 2024 13:13:26 -0500 Subject: [PATCH 10/12] remove unused portions of queries in case_docket --- app/models/vacols/case_docket.rb | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/app/models/vacols/case_docket.rb b/app/models/vacols/case_docket.rb index 56b4f4c5565..44e2d535d6c 100644 --- a/app/models/vacols/case_docket.rb +++ b/app/models/vacols/case_docket.rb @@ -121,19 +121,16 @@ class DocketNumberCentennialLoop < StandardError; end " SELECT_PRIORITY_APPEALS = " - select BFKEY, BFDLOOUT, VLJ, PREV_TYPE_ACTION, PREV_DECIDING_JUDGE + select BFKEY, BFDLOOUT, VLJ from ( select BFKEY, BFDLOOUT, - case when BFHINES is null or BFHINES <> 'GP' then VLJ_HEARINGS.VLJ end VLJ, - PREV_APPEAL.PREV_TYPE_ACTION PREV_TYPE_ACTION, - PREV_APPEAL.PREV_DECIDING_JUDGE PREV_DECIDING_JUDGE + case when BFHINES is null or BFHINES <> 'GP' then VLJ_HEARINGS.VLJ end VLJ from ( #{SELECT_READY_APPEALS} and (BFAC = '7' or AOD = '1') order by BFDLOOUT ) BRIEFF #{JOIN_ASSOCIATED_VLJS_BY_HEARINGS} - #{JOIN_PREVIOUS_APPEALS} ) " @@ -147,7 +144,6 @@ class DocketNumberCentennialLoop < StandardError; end from ( #{SELECT_READY_APPEALS} and (BFAC = '7' or AOD = '1') - order by BFDLOOUT ) BRIEFF #{JOIN_ASSOCIATED_VLJS_BY_HEARINGS} #{JOIN_PREVIOUS_APPEALS} @@ -156,10 +152,9 @@ class DocketNumberCentennialLoop < StandardError; end " SELECT_NONPRIORITY_APPEALS = " - select BFKEY, BFDLOOUT, VLJ, DOCKET_INDEX, PREV_TYPE_ACTION, PREV_DECIDING_JUDGE + select BFKEY, BFDLOOUT, VLJ, DOCKET_INDEX from ( select BFKEY, BFDLOOUT, rownum DOCKET_INDEX, - PREV_APPEAL.PREV_TYPE_ACTION PREV_TYPE_ACTION, PREV_APPEAL.PREV_DECIDING_JUDGE PREV_DECIDING_JUDGE, case when BFHINES is null or BFHINES <> 'GP' then VLJ_HEARINGS.VLJ end VLJ from ( #{SELECT_READY_APPEALS} @@ -167,7 +162,6 @@ class DocketNumberCentennialLoop < StandardError; end order by case when substr(TINUM, 1, 2) between '00' and '29' then 1 else 0 end, TINUM ) BRIEFF #{JOIN_ASSOCIATED_VLJS_BY_HEARINGS} - #{JOIN_PREVIOUS_APPEALS} ) " @@ -180,7 +174,6 @@ class DocketNumberCentennialLoop < StandardError; end from ( #{SELECT_READY_APPEALS} and BFAC <> '7' and AOD = '0' - order by case when substr(TINUM, 1, 2) between '00' and '29' then 1 else 0 end, TINUM ) BRIEFF #{JOIN_ASSOCIATED_VLJS_BY_HEARINGS} #{JOIN_PREVIOUS_APPEALS} From 1310f02e27f8f4e942ae0203c58928c414b92f95 Mon Sep 17 00:00:00 2001 From: Craig Reese Date: Tue, 21 May 2024 15:24:39 -0500 Subject: [PATCH 11/12] revert unneeded change to query order --- app/models/vacols/case_docket.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/models/vacols/case_docket.rb b/app/models/vacols/case_docket.rb index 44e2d535d6c..e4d0a3131bd 100644 --- a/app/models/vacols/case_docket.rb +++ b/app/models/vacols/case_docket.rb @@ -169,8 +169,9 @@ class DocketNumberCentennialLoop < StandardError; end select BFKEY, BFD19, BFDLOOUT, VLJ, DOCKET_INDEX, PREV_TYPE_ACTION, PREV_DECIDING_JUDGE from ( select BFKEY, BFD19, BFDLOOUT, rownum DOCKET_INDEX, - PREV_APPEAL.PREV_TYPE_ACTION PREV_TYPE_ACTION, PREV_APPEAL.PREV_DECIDING_JUDGE PREV_DECIDING_JUDGE, - case when BFHINES is null or BFHINES <> 'GP' then VLJ_HEARINGS.VLJ end VLJ + case when BFHINES is null or BFHINES <> 'GP' then VLJ_HEARINGS.VLJ end VLJ, + PREV_APPEAL.PREV_TYPE_ACTION PREV_TYPE_ACTION, + PREV_APPEAL.PREV_DECIDING_JUDGE PREV_DECIDING_JUDGE from ( #{SELECT_READY_APPEALS} and BFAC <> '7' and AOD = '0' From 8e2e1aaf64d78cd7788a1e6bedadd330c89e2349 Mon Sep 17 00:00:00 2001 From: Craig Reese Date: Tue, 21 May 2024 15:25:41 -0500 Subject: [PATCH 12/12] revert unneeded change to query order --- app/models/vacols/case_docket.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/models/vacols/case_docket.rb b/app/models/vacols/case_docket.rb index e4d0a3131bd..22893e7b475 100644 --- a/app/models/vacols/case_docket.rb +++ b/app/models/vacols/case_docket.rb @@ -169,9 +169,9 @@ class DocketNumberCentennialLoop < StandardError; end select BFKEY, BFD19, BFDLOOUT, VLJ, DOCKET_INDEX, PREV_TYPE_ACTION, PREV_DECIDING_JUDGE from ( select BFKEY, BFD19, BFDLOOUT, rownum DOCKET_INDEX, - case when BFHINES is null or BFHINES <> 'GP' then VLJ_HEARINGS.VLJ end VLJ, - PREV_APPEAL.PREV_TYPE_ACTION PREV_TYPE_ACTION, - PREV_APPEAL.PREV_DECIDING_JUDGE PREV_DECIDING_JUDGE + case when BFHINES is null or BFHINES <> 'GP' then VLJ_HEARINGS.VLJ end VLJ, + PREV_APPEAL.PREV_TYPE_ACTION PREV_TYPE_ACTION, + PREV_APPEAL.PREV_DECIDING_JUDGE PREV_DECIDING_JUDGE from ( #{SELECT_READY_APPEALS} and BFAC <> '7' and AOD = '0'