From f05eb814355e13850016b8e40004528c9501c5c0 Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Wed, 23 Oct 2024 14:33:27 -0500 Subject: [PATCH 1/6] synchronize chromedriver version --- .github/workflows/documentation_accessibility_checks.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/documentation_accessibility_checks.yml b/.github/workflows/documentation_accessibility_checks.yml index dfce804cd6e..1c7b058345d 100644 --- a/.github/workflows/documentation_accessibility_checks.yml +++ b/.github/workflows/documentation_accessibility_checks.yml @@ -18,15 +18,17 @@ jobs: run: npm cache clean --force - name: Install Axe CLI globally run: npm install -g @axe-core/cli@latest - - name: Update npm + - name: Update npm run: npm install -g npm@latest - uses: actions/setup-node@v3 with: node-version-file: 'VAMobile/.nvmrc' cache: yarn cache-dependency-path: VAMobile/yarn.lock - - name: Install ChromeDriver - run: npm install -g chromedriver@126.0.0 + - name: Install ChromeDriver using browser-driver-manager + run: | + npm install -g browser-driver-manager + npx browser-driver-manager install chrome - name: Test build working-directory: VAMobile run: | From 77f1a6521b4adb1ec531bbb6d3cc589193f9eb50 Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Wed, 23 Oct 2024 15:30:45 -0500 Subject: [PATCH 2/6] install chrome --- .github/workflows/documentation_accessibility_checks.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/documentation_accessibility_checks.yml b/.github/workflows/documentation_accessibility_checks.yml index 1c7b058345d..f25d44fa650 100644 --- a/.github/workflows/documentation_accessibility_checks.yml +++ b/.github/workflows/documentation_accessibility_checks.yml @@ -25,9 +25,10 @@ jobs: node-version-file: 'VAMobile/.nvmrc' cache: yarn cache-dependency-path: VAMobile/yarn.lock - - name: Install ChromeDriver using browser-driver-manager + - name: Install Chrome and ChromeDriver using browser-driver-manager run: | npm install -g browser-driver-manager + npx browser-driver-manager update chrome npx browser-driver-manager install chrome - name: Test build working-directory: VAMobile From 879b50428088d93775d0e81fb1bf94e05f99374c Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Wed, 23 Oct 2024 16:23:14 -0500 Subject: [PATCH 3/6] browser-driver-manager --- .github/workflows/documentation_accessibility_checks.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/documentation_accessibility_checks.yml b/.github/workflows/documentation_accessibility_checks.yml index f25d44fa650..acbf220e5e3 100644 --- a/.github/workflows/documentation_accessibility_checks.yml +++ b/.github/workflows/documentation_accessibility_checks.yml @@ -27,8 +27,8 @@ jobs: cache-dependency-path: VAMobile/yarn.lock - name: Install Chrome and ChromeDriver using browser-driver-manager run: | - npm install -g browser-driver-manager - npx browser-driver-manager update chrome + npx browser-driver-manager install chrome + npx browser-driver-manager install chrome - name: Test build working-directory: VAMobile From 972283e3132595d1ce163a66b8e14dfdf54a7c13 Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Wed, 23 Oct 2024 16:23:52 -0500 Subject: [PATCH 4/6] browser-driver-manager --- .github/workflows/documentation_accessibility_checks.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/documentation_accessibility_checks.yml b/.github/workflows/documentation_accessibility_checks.yml index acbf220e5e3..1303aaa9203 100644 --- a/.github/workflows/documentation_accessibility_checks.yml +++ b/.github/workflows/documentation_accessibility_checks.yml @@ -26,9 +26,7 @@ jobs: cache: yarn cache-dependency-path: VAMobile/yarn.lock - name: Install Chrome and ChromeDriver using browser-driver-manager - run: | - npx browser-driver-manager install chrome - + run: | npx browser-driver-manager install chrome - name: Test build working-directory: VAMobile From 87f56b09330cf2d8154f4fe120f8e41a1757f5c5 Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Wed, 23 Oct 2024 16:29:22 -0500 Subject: [PATCH 5/6] latest chrodriver --- .github/workflows/documentation_accessibility_checks.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/documentation_accessibility_checks.yml b/.github/workflows/documentation_accessibility_checks.yml index 1303aaa9203..5acef980b18 100644 --- a/.github/workflows/documentation_accessibility_checks.yml +++ b/.github/workflows/documentation_accessibility_checks.yml @@ -26,8 +26,7 @@ jobs: cache: yarn cache-dependency-path: VAMobile/yarn.lock - name: Install Chrome and ChromeDriver using browser-driver-manager - run: | - npx browser-driver-manager install chrome + run: npm install -g chromedriver@latest - name: Test build working-directory: VAMobile run: | From 46c8335eb76dd9ee2769fc2284b39a8d6cf15ddf Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Wed, 23 Oct 2024 16:49:16 -0500 Subject: [PATCH 6/6] Ready for review --- .github/workflows/documentation_accessibility_checks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/documentation_accessibility_checks.yml b/.github/workflows/documentation_accessibility_checks.yml index 5acef980b18..ba349c755e8 100644 --- a/.github/workflows/documentation_accessibility_checks.yml +++ b/.github/workflows/documentation_accessibility_checks.yml @@ -25,7 +25,7 @@ jobs: node-version-file: 'VAMobile/.nvmrc' cache: yarn cache-dependency-path: VAMobile/yarn.lock - - name: Install Chrome and ChromeDriver using browser-driver-manager + - name: Install latest version of chromeDriver run: npm install -g chromedriver@latest - name: Test build working-directory: VAMobile