Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating App Unit Tests to use i18n Translations - Benefits (Disability Rating) #10020

Open
2 tasks
dumathane opened this issue Oct 23, 2024 · 0 comments
Open
2 tasks

Updating App Unit Tests to use i18n Translations - Benefits (Disability Rating) #10020

dumathane opened this issue Oct 23, 2024 · 0 comments
Labels
code upkeep front-end Ticket requires front-end work global Issues for the global team Good first issue An issue that's suitable for someone looking to contribute for the first time

Comments

@dumathane
Copy link
Contributor

dumathane commented Oct 23, 2024 •
edited
Loading

Proposed Change

Update the following tests to use the i18n translations instead of hardcoded strings:

  • VAMobile/src/screens/BenefitsScreen/DisabilityRatingsScreen/NoDisabilityRatings/NoDisabilityRatings.test.tsx
  • VAMobile/src/screens/BenefitsScreen/DisabilityRatingsScreen/DisabilityRatingsScreen.test.tsx

Why Should We Prioritize?

This will make our unit tests less brittle while remaining vigilant in our coding defense.

Coding Time Estimation

2

Testing Considerations

Checklist

  • Add the relevant team label (Health, global, design system, API, Qa and Release etc.)
  • Attach to ticket to the relevant Team Tech Debt Epic epic (old frontend engineering epic is no longer in use as each team is managing their code's technical debt and code upkeep work)
@dumathane dumathane added code upkeep front-end Ticket requires front-end work global Issues for the global team Good first issue An issue that's suitable for someone looking to contribute for the first time labels Oct 23, 2024
@dumathane dumathane changed the title Copy of Updating App Unit Tests to use i18n Translations - Benefits (Claims-9) Updating App Unit Tests to use i18n Translations - Benefits (Letters) Oct 23, 2024
@dumathane dumathane changed the title Updating App Unit Tests to use i18n Translations - Benefits (Letters) Updating App Unit Tests to use i18n Translations - Benefits (Disability Rating) Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code upkeep front-end Ticket requires front-end work global Issues for the global team Good first issue An issue that's suitable for someone looking to contribute for the first time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dumathane