Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage modal session logic: modal does not appear when expected on new sessions #11976

Closed
2 tasks
jilladams opened this issue Dec 15, 2022 · 0 comments
Closed
2 tasks
Labels
Needs refining Issue status Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area VA.gov homepage CMS managed product owned by Public Websites team

Comments

@jilladams
Copy link
Contributor

jilladams commented Dec 15, 2022

Session logic written in #11817 merged and was rebased into Josh's PR for #11535.

Using the Review instance for 11535 PR, I'm testing from http://a109d22ff3eebd5144235d7057fb577f.review.vetsgov-internal/, where both modal build and session logic are present.

Test cases

For each case, open http://a109d22ff3eebd5144235d7057fb577f.review.vetsgov-internal/, close the modal. Then:

🟢 Refresh page: Modal does not appear
🔴 Open a new browser tab and load http://a109d22ff3eebd5144235d7057fb577f.review.vetsgov-internal/: Modal does not appear
🔴 Quit browser. Open browser. Load http://a109d22ff3eebd5144235d7057fb577f.review.vetsgov-internal/: Modal does not appear

In order to get modal to reappear for the 2 failing cases, I have to first clear local storage. (localStorage.clear();).

Acceptance Criteria

  • The soft-launch modal shows once per browser tab/window, regardless of how the visitor exits the modal (ie, dismisses the modal or follows the link to see the new homepage)
  • Requires product review
@jilladams jilladams added Needs refining Issue status VA.gov frontend CMS team practice area VA.gov homepage CMS managed product owned by Public Websites team Public Websites Scrum team in the Sitewide crew labels Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs refining Issue status Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area VA.gov homepage CMS managed product owned by Public Websites team
Projects
None yet
Development

No branches or pull requests

1 participant