Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAMC story and news release pagination is not announced properly #12089

Open
3 tasks
laflannery opened this issue Dec 22, 2022 · 8 comments
Open
3 tasks

VAMC story and news release pagination is not announced properly #12089

laflannery opened this issue Dec 22, 2022 · 8 comments
Assignees
Labels
a11y-defect-2 Serious accessibility issue that should be fixed in the next 1-2 sprints accessibility Issues related to accessibility Defect Something isn't working (issue type) Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team

Comments

@laflannery
Copy link
Contributor

laflannery commented Dec 22, 2022

Describe the defect

On the VAMC Stories and News Releases pages, the search results are not properly announced to a non-visual user when using the pagination. This makes it difficult to fully understand the results.

To Reproduce

Steps to reproduce the behavior:

  1. Go to a page on within the VAMC that has paging, like Boston news releases
  2. Turn your screen reader on
  3. Go to page 2 of the results list
  4. Confirm that you are directed to the top of page 2 and "Current" is announced, instead of the number of new results on the page

Additional Context

  • The search results should behave the same as the other searches throughout the VA.gov site (i.e Find a form, Resources and Support)
  • It's interesting that these listings don't have a "Showing X - XX of XXX results" at the top of the listing. If this was present we could send focus to this as we do on the PW listings. Is there a product reason we don't do this or could this be added?

AC / Expected behavior

  • Update search results to announce new results on the page.
  • Accessibility review
  • Platform sister issue (#64843) should be closed when this work is done.
@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Dec 22, 2022
@laflannery laflannery changed the title Events search results are not being announced properly VAMC search results are not being announced properly Dec 23, 2022
@laflannery laflannery added accessibility Issues related to accessibility a11y-defect-2 Serious accessibility issue that should be fixed in the next 1-2 sprints labels Dec 23, 2022
@laflannery laflannery added the VAMC CMS managed product owned by Facilities team label Feb 27, 2023
@laflannery laflannery added VA.gov frontend CMS team practice area Still Applicable Issue has been reviewed and determined to be still valid labels Jul 6, 2023
@mmiddaugh mmiddaugh changed the title VAMC search results are not being announced properly VAMC event, story, and news release pagination is not announced properly Aug 7, 2023
@eselkin
Copy link
Contributor

eselkin commented Aug 8, 2023

I think the current here is related to jumping to the content immediately. In form search it jumps (when you click page 2) to the next set of form items. In the event, story, news release the page 2 jumps to the top of the screen and does not announce the next items until you tab your way down the page a bit.

So I guess this is still reproducible.

@jilladams jilladams removed the Triage label Aug 9, 2023
@randimays
Copy link
Contributor

Somewhat related defect that could use a look on the Facilities events page: #14737

@mmiddaugh
Copy link
Contributor

Is this related to #12088?

@laflannery
Copy link
Contributor Author

@mmiddaugh I think an engineer is going to have to answer this definitively but I feel like no - I think additional work has to go into this beyond just waiting for the DST to update their component class

@xiongjaneg xiongjaneg added the UX label Aug 21, 2023
@CherylEvans
Copy link

This ticket was recreated in va.gov-team repo Ticket # 64843

@laflannery laflannery removed the Still Applicable Issue has been reviewed and determined to be still valid label Sep 5, 2023
@davidmpickett davidmpickett removed the UX label Sep 21, 2023
@laflannery laflannery added the Needs refining Issue status label Nov 9, 2023
@xiongjaneg xiongjaneg changed the title VAMC event, story, and news release pagination is not announced properly VAMC story and news release pagination is not announced properly Feb 7, 2024
@xiongjaneg
Copy link
Contributor

@xiongjaneg Remove this from V3 upgrade tickets

@xiongjaneg xiongjaneg removed the Needs refining Issue status label Feb 7, 2024
@Agile6MSkinner
Copy link

@laflannery to revaluate ACs

@Agile6MSkinner Agile6MSkinner added the Defect Something isn't working (issue type) label Aug 28, 2024
@laflannery
Copy link
Contributor Author

@Agile6MSkinner This is all set, there is a product question in the "Additional Context" section that should probably be answered before this goes to the team for refinement. That being said, I will move this to Backlog until this is answered.

@Agile6MSkinner Agile6MSkinner self-assigned this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y-defect-2 Serious accessibility issue that should be fixed in the next 1-2 sprints accessibility Issues related to accessibility Defect Something isn't working (issue type) Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

9 participants